FindInFiles converted to command and accepting arguments#71626
FindInFiles converted to command and accepting arguments#71626roblourens merged 3 commits intomicrosoft:masterfrom
Conversation
|
|
|
@roblourens - Code is modified to use an args variable when calling setSearchParameters (which is renamed) Did you get a few minutes to think about the trigger search parameter? |
roblourens
left a comment
roblourens
left a comment
There was a problem hiding this comment.
Merging this, but I am going to keep thinking about triggerSearch, and I reserve the right to revert it before the next stable release :)
Thanks for the PR!
|
Btw, thinking about it more, I think all of this is fine, including allowing an extension to trigger the search, and I look forward to seeing what people use it for! |
|
Thanks @roblourens, that was good news on a Friday night. 👍 |
|
@roblourens , is this included in the v1.34 release? Didn't see anything in the release notes. ;-) |
|
Yep it's there |
OK, thanks |
|
Oh I forgot to add this to the milestone so it wasn't included in the release notes. I'll fix that and it will show up next time the website is updated. Sorry! |
3 participants
Tries to solve #29405