fix-71570 Error when restoring a markdown preview for a file that has been deleted#71762
Merged
mjbvz merged 3 commits intomicrosoft:masterfrom Apr 12, 2019
Merged
fix-71570 Error when restoring a markdown preview for a file that has been deleted#71762mjbvz merged 3 commits intomicrosoft:masterfrom
mjbvz merged 3 commits intomicrosoft:masterfrom
Conversation
mjbvz
requested changes
Apr 5, 2019
Collaborator
mjbvz
left a comment
mjbvz
left a comment
There was a problem hiding this comment.
Good direction. Let me know if you have any questions about my suggested changes
extensions/markdown-language-features/src/features/previewContentProvider.ts
Outdated
Show resolved
Hide resolved
* upstream/master: (34 commits) Fix markdown.styled regression caused by Uri.parse changes Process explorer refactoring fix compile error fix open workspace uri from cli Delete deprecated search provider stub test dependenices are devDependencies Fix default uri when scheme is file disable flaky test, microsoft#71801 use `readonly T[]` instead of `ReadonlyArray<T>` simplify protocol check Let enablment service handles local workspace extensions in remote window debt - make ext host init data more complete Fix colorization tests fixes microsoft#71671 Update grammars Add yes-no choice for overwriting existing file for save as update distro ExtensionEnablementService: - Remove getDisabledExtensions and instead use isEnabled or getEnablementState methods Simplify reload action and fix test Update distro hash ...
Contributor
Author
|
@mjbvz , Changes are pushed :) |
Contributor
Author
|
@mjbvz sorry , did you get time to look at the changes ? |
Collaborator
|
Thanks! Will be in the next VS Code insiders and is scheduled to ship with the April update |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@mjbvz , Added logic to handle preview update when a file is renamed or deleted to fix #71570 , tested it on my local and works fine :)
PS : The Error html return value that is shown can be changed if its too simple :)
Please review it and let me know if there needs to be any other changes :)