Merged
Conversation
Contributor
|
@LeuisKen Thanks for helping. I'd suggest to make the fix in apiCommands. |
Change-Id: I25f92e400ef2f999d604e5ca97637145142de1a1
Contributor
|
Looks good, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is two way to fix this issue, and because I think this bug is caused by mistake, so I just revert the implements.
And I think the case needs a test to cover, but I didn't find
vscode.openFoldertest, I'll really appreciate if someone can teach me how to do this.Thanks. : )