Makefile test case about the bug fix with "@,-,+" colorizing in the recipe#72265
Merged
alexr00 merged 2 commits intomicrosoft:masterfrom Apr 16, 2019
fadeevab:makefile-update
Merged
Makefile test case about the bug fix with "@,-,+" colorizing in the recipe#72265alexr00 merged 2 commits intomicrosoft:masterfrom fadeevab:makefile-update
alexr00 merged 2 commits intomicrosoft:masterfrom
fadeevab:makefile-update
Conversation
…ecipe. Bug: regex [@-+] means "from @ to +", so "." and "\" was also colorized. Bug is fixed in make.tmbundle, test case is added to vscode.
Contributor
Author
|
Test cases will pass after grammar update! |
alexr00
approved these changes
Apr 16, 2019
Member
alexr00
left a comment
alexr00
left a comment
There was a problem hiding this comment.
Thank you for the new test case! I'm including the grammar update in this PR too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I updated make.tmbundle, there is a little bugfix. So need to update test cases in VSCode.
Bug: regex [@-+] means "from @ to +", so "." and "" was also colorized.
Bug is fixed in make.tmbundle, test case is added to vscode.