json-language-features/CONTRIBUTING.md fixes#73273
Merged
aeschli merged 1 commit intomicrosoft:masterfrom May 7, 2019
Merged
Conversation
In particular, mention npm and yarn as appropriate. Some of the mentions had apparently been inadvertantly switched???
Contributor
|
Agree that we should be consistent (either yarn or npm), Yourpull request, however, keeps the inconsistency. Can we use yarn everywhere? |
Contributor
Author
|
Well, that would be possible, but it doesn't appear to be consistent with what's currently checked into https://github.com/microsoft/vscode-json-languageservice at the moment. In particular, it has a (Aside: Is it just me, or was there a capital M in microsoft yesterday?) |
Contributor
|
Ok, I see, you are right. For JSON we still haven't switched from |
aeschli
approved these changes
May 7, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In particular, mention npm and yarn as appropriate.
Some of the mentions had apparently been inadvertantly switched???