Use a newer version of @types/node in the build folder to match all other folders#77784
Merged
mjbvz merged 2 commits intomicrosoft:masterfrom Jul 23, 2019
Merged
Conversation
Collaborator
|
Thanks @weswigham. Can you please just run yarn in the build directory too to update the lock file. That's what caused the build to fail |
…er node declarations
Member
Author
|
@mjbvz done - I had to bump the |
mjbvz
approved these changes
Jul 22, 2019
joaomoreno
approved these changes
Jul 23, 2019
Member
joaomoreno
left a comment
joaomoreno
left a comment
There was a problem hiding this comment.
This LGTM but @jrieken might want to check the monaco-editor compile task.
Member
Green build means that it's happy |
Collaborator
|
Thanks @weswigham! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The old node 8 definitions will throw on TS 3.6 with
every other package file was already using a caret-version referencing node 10, so I just adjusted the
buildfolder to do the same (a newer version of the node 8 types could also be used, but given that this was the odd package file out, I assume it was just an oversight during some upgrade process).