Fix mightProducePrintableCharacter numeric keypad support#77911
Merged
alexdima merged 7 commits intomicrosoft:masterfrom Jan 13, 2020
Merged
Fix mightProducePrintableCharacter numeric keypad support#77911alexdima merged 7 commits intomicrosoft:masterfrom
alexdima merged 7 commits intomicrosoft:masterfrom
Conversation
Merged
joaomoreno
requested changes
Oct 25, 2019
src/vs/workbench/services/keybinding/browser/keybindingService.ts
Outdated
Show resolved
Hide resolved
src/vs/workbench/services/keybinding/browser/keybindingService.ts
Outdated
Show resolved
Hide resolved
Member
|
@alexandrudima I need your expertise here to figure out whether this is a smart thing to do. |
|
Hello, do you have news for this bug to be fixed ? |
|
Do you have news please ? |
Member
|
Thank you! |
Member
|
Thanks @alexdima! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #71134.
I tested it on ubuntu 18.04. Needs to be tested on windows.