Skip to content

Added focusSearch() into clearSearchResults() and got rid of duplicate function#83617

Merged
roblourens merged 1 commit intomicrosoft:masterfrom
smilegodly:removeDuplicateFuntion
Nov 24, 2019
Merged

Added focusSearch() into clearSearchResults() and got rid of duplicate function#83617
roblourens merged 1 commit intomicrosoft:masterfrom
smilegodly:removeDuplicateFuntion

Conversation

@smilegodly
Copy link
Contributor

@smilegodly smilegodly commented Oct 30, 2019

Added 'focusSearch' method to 'clearSearchResults' in the settings editor.. Also Got rid of a duplicate function that clears the search bar in the settings editor.

This PR fixes #83623

@smilegodly smilegodly changed the title Deleted a duplicate method in settings editor Added focus search method to clear search results and got rid of duplicate function Oct 30, 2019
@smilegodly smilegodly changed the title Added focus search method to clear search results and got rid of duplicate function Added focusSearch() to clearSearchResults() and got rid of duplicate function Oct 30, 2019
@smilegodly smilegodly changed the title Added focusSearch() to clearSearchResults() and got rid of duplicate function Added focusSearch() into clearSearchResults() and got rid of duplicate function Oct 30, 2019
@roblourens
Copy link
Member

Make sure you set your git email address so the commit will be correctly associated with your github account!

@roblourens roblourens added this to the November 2019 milestone Oct 30, 2019
Modified focus search bar to be part of clearing search bar function.
@smilegodly smilegodly force-pushed the removeDuplicateFuntion branch from 549cef2 to 33c241b Compare October 30, 2019 20:49
@smilegodly
Copy link
Contributor Author

smilegodly commented Oct 30, 2019

I think it's setup properly now.
Please let me know if there are any other issues..
Thanks!
@roblourens

@roblourens roblourens merged commit 5389d4e into microsoft:master Nov 24, 2019
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Clear Search Bar function doesn't refocus by current definition in the settings editor

2 participants