Cleanup extHostTerminalService.ts#84404
Cleanup extHostTerminalService.ts#84404Tyriar merged 3 commits intomicrosoft:masterfrom solomatov:cleanup_ext_host_terminals
Conversation
remove dead code
|
@Tyriar Any updates on this? |
| } else { | ||
| this._getTerminalPromises[id].then(c => { | ||
| return this._createGetTerminalPromise(id, retries); | ||
| }); |
There was a problem hiding this comment.
I think the purpose of this code was to handle the case where the promise this._getTerminalPromises[id] resolves to undefined. It definitely doesn't work currently but that might be a case that's still an issue.
There was a problem hiding this comment.
@Tyriar But it doesn't return anything, so no effect. Or was there any side effect of invoking _getTerminalByIdEventually in code before some of the changes?
There was a problem hiding this comment.
Yeah it definitely didn't work so it's fine to remove, I think we're still missing that case though. Ideally the resolve function would be kept around, similar to how id promise works on BaseExtHostTerminal:
vscode/src/vs/workbench/api/common/extHostTerminalService.ts
Lines 41 to 42 in 9e899b5
2 participants
Please, correct me if I made something wrongly.