Fix opening image with '%' in the filename#84667
Fix opening image with '%' in the filename#84667mjbvz merged 2 commits intomicrosoft:masterfrom onequid:83165-cannot_open_file_with_percent_mark
Conversation
|
|
|
By the way, do you any conventions for |
|
I believe this was originally added to handle file names with spaces in the name. Can you please confirm images with names like |
| @@ -223,15 +223,15 @@ class Preview extends Disposable { | |||
| private getResourcePath(webviewEditor: vscode.WebviewPanel, resource: vscode.Uri, version: string) { | |||
| switch (resource.scheme) { | |||
| case 'data': | |||
There was a problem hiding this comment.
What user operation or situation would run codes in the case 'data'?
I guess that the case 'git' part would be fine. Not sure about the case 'data' section.
|
I see, I didn't think of the spaces. I am still concerned about another |
|
Thanks! This will be in the next insiders build and is scheduled to be shipped with VS Code 1.41 |
|
Glad to know that! My pleasure! Thanks! |
|
This broke loading of images with spaces in the name. Given that these are more common than images with |
|
I assume that both PR (this and #84334 ) would locate the same cause, and only one of them should be merged. It is more about which to merge. Merging this PR solely won't break anything as far as I tested, in my defence. |
3 participants
This PR fixes #83165 opening image with '%' in the filename
Please let me know how to write tests for this if it is required as I don't have a clue.
I have no idea in what situation
schemewould be as 'git' or 'data' neither, please give advice and I would try it out