Skip to content

Show JS/TS References Code Lens for Inner Functions#84689

Merged
mjbvz merged 5 commits intomicrosoft:masterfrom
okmttdhr:inner-function-code-lens
Nov 23, 2019
Merged

Show JS/TS References Code Lens for Inner Functions#84689
mjbvz merged 5 commits intomicrosoft:masterfrom
okmttdhr:inner-function-code-lens

Conversation

@okmttdhr
Copy link
Contributor

This PR fixes #22981

@okmttdhr okmttdhr changed the title WIP Show JS/TS References Code Lens for Inner Functions Show JS/TS References Code Lens for Inner Functions Nov 13, 2019
@okmttdhr okmttdhr marked this pull request as ready for review November 13, 2019 13:00
@okmttdhr okmttdhr requested a review from mjbvz November 14, 2019 13:56
@okmttdhr okmttdhr force-pushed the inner-function-code-lens branch from 12b4faa to 1d7d80b Compare November 16, 2019 05:41
@okmttdhr okmttdhr force-pushed the inner-function-code-lens branch from f7d1a8a to 6f20e9e Compare November 22, 2019 10:12
@okmttdhr okmttdhr requested a review from mjbvz November 22, 2019 10:17
@okmttdhr okmttdhr requested a review from mjbvz November 23, 2019 00:58
@mjbvz mjbvz added this to the November 2019 milestone Nov 23, 2019
@mjbvz mjbvz merged commit 0db887a into microsoft:master Nov 23, 2019
@mjbvz
Copy link
Collaborator

mjbvz commented Nov 23, 2019

Thanks! Will be in next insiders build

@okmttdhr okmttdhr deleted the inner-function-code-lens branch November 23, 2019 07:17
@tomillie
Copy link

I now have references almost on every line. Was that intended?

image

@okmttdhr
Copy link
Contributor Author

@tomillie
I think this is not related to this PR.

We need to add a new setting around here (or show references not for every property).
https://github.com/okmttdhr/vscode/blob/ec20ba205cee4b63e6162ae551d3ca9e19f53dda/extensions/typescript-language-features/src/features/referencesCodeLens.ts#L92-L96

@tomillie
Copy link

It's been fixed.
#86495

@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Show JS/TS References Code Lens for Inner Functions

3 participants