fix #82457, markdown open, but unfocused source tab#85506
Merged
mjbvz merged 1 commit intomicrosoft:masterfrom Nov 25, 2019
Merged
fix #82457, markdown open, but unfocused source tab#85506mjbvz merged 1 commit intomicrosoft:masterfrom
mjbvz merged 1 commit intomicrosoft:masterfrom
Conversation
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #82457.
This fix first opens the source tab of the currently focused markdown file using the
showSourcecommand. This would make the source tab part ofvscode.window.visibleTextEditors, which can be iterated over and the appropriate line to select can be set. This makes sure that if the source tab is already open but unfocused, double clicking on a line in markdown will not create another tab of the markdown source file.Testing: steps for reproduction provided by @GehDoc in #82457
Current behavior: new tab opened for source markdown file
Expected behavior: unfocused source file tab is focused