@Yoric I am uncertain if this might break the popular mercurial VSCode extension that relies on file events from HG folders:

https://github.com/mrcrowl/vscode-hg/blob/6bee18442233a1ec34fecd6033a934a3052e20ee/src/model.ts#L123

Maybe you could follow up with @mrcrowl if it would be ok to exclude .hg/store by default.

With pleasure. Is there a good way to get in touch with @mrcrowl?

I am not sure how active that account it, let's see if this ping comes back. Otherwise maybe a mail could work?

Sorry, yeah I haven't been actively maintaining the Hg extension for a while, because my company switched to git, and my initial motivation was to encourage a switch to vscode from Visual Studio. Have been advertising for a motivated maintainer, but none has come forward.

It is heavily based on an earlier version of the baked-in git scm extension. It creates a filesystem watcher workspace.createFileSystemWatcher('**') and then filters to all events in the root .hg folder in order to detect external changes to the repo. It's not specifically watching .hg/store, however it may well be one of the places that would be touched when external events occur.

I don't want to hold up your PR, so thinking you could test this quickly on a basic Hg repo. Unfortunately, I'm not going to have an opportunity to try this myself in the next short while.

@mrcrowl thanks for the message 👍

@Yoric since you seem to be a client of this extension (?) could you do this:

I don't want to hold up your PR, so thinking you could test this quickly on a basic Hg repo. Unfortunately, I'm not going to have an opportunity to try this myself in the next short while.

I'm actually not a client of the extension, but I can test it!

@Yoric thanks a ton

@Yoric any update?

So far, I haven't noticed anything bad happening, but I'll admit that I haven't checked very carefully. For some reason, the coronavirus scare seems to decrease the rhythm at which rebase my tree.

Fair enough, I suggest we try it out in insiders for March and wait for feedback.