fix typing for proxy auth window options#91954
Merged
bpasero merged 2 commits intomicrosoft:masterfrom Mar 3, 2020
bennycode:master
Merged
fix typing for proxy auth window options#91954bpasero merged 2 commits intomicrosoft:masterfrom bennycode:master
bpasero merged 2 commits intomicrosoft:masterfrom
bennycode:master
Conversation
Member
|
Thanks, the explicit use of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a missing type for the construction options of the browser window which renders the proxy auth modal. It's a small change but it gives more control of the
optsobject and makes the code consistent with other files that also apply theBrowserWindowConstructorOptionstyping, i.e.:vscode/src/vs/code/electron-main/window.ts
Line 125 in 9eedabc