Alert input box messages anytime shown#92531
Merged
isidorn merged 1 commit intomicrosoft:masterfrom Mar 12, 2020
Merged
Conversation
Collaborator
|
@Charles-Gagnon thanks for your PR, this makes sense. I have tried it out and this works good for me. |
isidorn
added
the
accessibility
This was referenced Mar 12, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a fix for an issue that was brought up in an accessibility review of Azure Data Studio : microsoft/azuredatastudio#9175
The issue is that if a message is shown the alert is read the first time - but if the user tabs out (hiding the message) and then back in (showing the message box again) the message is not read again which means that unless the user retained the context that a message was displayed they wouldn't know it was there.
The fix here is to always fire the alert whenever the message is displayed instead of just when showMessage is called (which isn't called when focus is gained through other means such as tab for example).