Allow users to make the scrollbars in the title area larger#92720
Conversation
|
|
|
Thanks, this seems to work pretty well. Adding @alexdima for the changes on the scrollbar itself and @jrieken for breadcrumb. I wonder if we should have just 1 setting for breadcrumb and tabs, however this may be challenging because after all tabs have more height available compared to breadcrumbs. @JohnnyCrazy one early feedback I have is to add an upper limit for the scrollbar height so that people do not end up with the scrollbar taking the entire space. E.g. something like 50% of the height we set for the parent container.
|
|
Idk - this a good idea? Do we want settings for each scrollbar? What about the peek-errors - users have complaint about that one too. Isn't the better approach to have one scrollbar height setting? |
|
@jrieken yeah but as far as I know, we use a consistent size for the scrollbar in all other places, only the editor tabs and breadcrumbs use a smaller height. Fair though, we probably need a setting for all other scrollbars too if we wanted to be consistent. |
If breadcrumbs and tabs are really the only two special height cases that we should maybe have a setting for that, or a setting for the "special height" scrollbar. I wouldn't allow a number but something symbolic, like "small" and "default". |
|
Yeah I like that, we could have then just have 1 setting for both scrollbars. |
|
I think a setting for each scrollbar would be too much hassle to maintain/configure for both, the user and the developer.
I like the idea of having a symbolic setting and I could imagine most users who complained about the small tab/breadcrumbs scrollbar don't want to specify a specific pixel number; they just want it to be better grabbable. This would also remove the need of a max height boundary and different parent sizes are no problem. The naming of such a setting is not easy though,
Isn't the size of all other scrollbars a little bit too large for the breadcrumbs list? It would be 14px.
If we find some consent, would be happy to refactor the PR :) |
|
Yeah, I would pick a sensible default for the larger scrollbar that works. Maybe |
|
If we limit the setting to the title bar, sounds good @jrieken mentioned peek-errors, should they also be included in this change? then we would need a different name |
|
I would not open the door to all the other places just yet. |
…ub.com:JohnnyCrazy/vscode into t-jodell/tab-and-breadcrumbs-scrollbar-heights
…ting, default and large
|
I updated the PR and introduced Large defaults:
|
JohnnyCrazy
changed the title
bpasero
left a comment
bpasero
left a comment
There was a problem hiding this comment.
@JohnnyCrazy pushed a bit of cleanup in b0ebbd0.
LGTM, waiting for @jrieken and @alexdima for thoughts on the changes in their areas.
alexdima
left a comment
alexdima
left a comment
There was a problem hiding this comment.
LGTM. I also pushed a change to use updateOptions to update the horizontal scrollbar size.
|
Thanks @JohnnyCrazy |
5 participants
This PR fixes #32192
It introduces two new settings:
workbench.editor.tabScrollbarHeight- Specify the size of the scrollbar used in the Tab listbreadcrumbs.scrollbarHeight- Specify the size of the scrollbar used in the breadcrumbs listIt updates in real-time, a small demo can be seen here:
Implementation wise, it's my first code change in VSCode, so I'm quite new to the architecture and I'm not sure if I chose the correct locations. Especially the
constructorchange inbreadcrumbsWidget.ts. I'm looking forward to your feedback :)