Inherit theme text colour in Settings Editor's section headings#93605
Merged
roblourens merged 2 commits intomicrosoft:masterfrom Mar 28, 2020
robertrossmann:feat/preferences-title-colours
Merged
Inherit theme text colour in Settings Editor's section headings#93605roblourens merged 2 commits intomicrosoft:masterfrom robertrossmann:feat/preferences-title-colours
roblourens merged 2 commits intomicrosoft:masterfrom
robertrossmann:feat/preferences-title-colours
Conversation
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have made the Settings' split-screen JSON editor's section titles to inherit the default text colour instead of using a hard-coded semi-white. Now the section titles look much better with themes which use non-white text colour. See the screens for before/after comparison.
Remedy
Before
After
Kimbie
Before
After
Tomorrow Night Blue
Before
After
