Skip to content

Inherit theme text colour in Settings Editor's section headings#93605

Merged
roblourens merged 2 commits intomicrosoft:masterfrom
robertrossmann:feat/preferences-title-colours
Mar 28, 2020
Merged

Inherit theme text colour in Settings Editor's section headings#93605
roblourens merged 2 commits intomicrosoft:masterfrom
robertrossmann:feat/preferences-title-colours

Conversation

@robertrossmann
Copy link
Contributor

I have made the Settings' split-screen JSON editor's section titles to inherit the default text colour instead of using a hard-coded semi-white. Now the section titles look much better with themes which use non-white text colour. See the screens for before/after comparison.

Remedy

Before
remedy - before

After
remedy - after

Kimbie

Before
kimbie - before

After
kimbie - after

Tomorrow Night Blue

Before
tnb - before

After
tnb - after

@roblourens roblourens merged commit 1ec4377 into microsoft:master Mar 28, 2020
@roblourens roblourens added this to the March 2020 milestone Mar 28, 2020
@roblourens
Copy link
Member

Thanks!

@robertrossmann robertrossmann deleted the feat/preferences-title-colours branch March 28, 2020 21:02
@github-actions github-actions bot locked and limited conversation to collaborators May 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants