Use ResizeObserver for monaco editor automaticLayout#93630
Merged
alexdima merged 2 commits intomicrosoft:masterfrom Mar 29, 2020
nrayburn-tech:resizeobserver
Merged
Use ResizeObserver for monaco editor automaticLayout#93630alexdima merged 2 commits intomicrosoft:masterfrom nrayburn-tech:resizeobserver
alexdima merged 2 commits intomicrosoft:masterfrom
nrayburn-tech:resizeobserver
Conversation
Contributor
Author
|
I am not sure if the types for ResizeObserver belong at the top of the file, they are temporary because they are not currently in typescript, ts issue. The I dropped the @alexdima let me know if anything needs to be changed, I just wanted to mention a few concerns before marking it as "Ready for review". |
Member
|
This is great, thank you! |
stefan-lacatus
added a commit
to thingworx-field-work/MonacoEditorTWX
that referenced
this pull request
Apr 1, 2020
This temporary fix resolves a regression caused by updating monaco to 0.20.0 Will be fixed properly once microsoft/vscode#93630 is released
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the MutationObserver with ResizeObserver. Uses a timeout for any browser that does not support ResizeObserver. (Safari is the only one of the currently supported browsers without ResizeObserver.)
When resizing an editor with a dynamic size (i.e. a percentage for the width), the editor should resize automatically.
This PR fixes #1855, fixes #1878 in monaco-editor.
Might fix #1884 as well.
This PR replaces #90111.