Adds setting to disable cursor movement while typing into Find Widget#94825
Adds setting to disable cursor movement while typing into Find Widget#94825rebornix merged 4 commits intomicrosoft:masterfrom ultraGentle:master
Conversation
rebornix
left a comment
There was a problem hiding this comment.
It seems the file is formatted by some formatters accidentally
|
Sorry about that. EDIT: fixed. |
|
@rebornix I believe I fixed the formatting issue. Any next steps you need from me? |
|
|
|
@briankendall Can you verify that you un-selected There is an unrelated, pre-existing setting The reason I ask is that @rebornix confirmed it worked in #60977 (comment) , and this PR is the same as my original, just behind a setting, so I thought maybe you just ticked the wrong one. Maybe the naming could be clearer. |
|
@ultraGentle You're right, I changed the wrong setting! It is in fact working for me. |
|
@rebornix I just made another commit:
-- As always, I'd appreciate any feedback on what I need to do to get this successfully merged. Thanks for considering! |
|
Any update on this getting merged? |
|
Same, I'd love to have this |
|
I haven't heard from @rebornix that any changes are necessary, and as far as I can tell, all testers have had positive experiences with no issues. Hoping this will make it into next month's update! |
|
Ok that would be great, looking forward to it. |
|
@adamreisnz , I think I implied that this will make it into the next release. If so, sorry -- that was just me hoping along with everyone else on this thread! I unfortunately don't have any insider info to share. I can't tell whether this is just pending, or has been dropped. |
|
Excited and hopeful to have this merged. |
|
I'm not sure what the deal is with radio silence from the VSCode team regarding this issue. I've already pinged the reviewer, with no response, and I don't want to be a squeaky wheel, so it's not clear to me what the way forward is. If I knew there were a problem, I'd fix it, but without any feedback I'm flummoxed. It's very strange to me, since this is a small PR and it fixes a super annoying bug, but I know folks are busy, so maybe there just hasn't been time for them to re-review and merge? Or maybe there's something else holding it up? The opacity here is a disincentive to contribute to other issues, since it feels futile to work on something if it's not going to end up in the final product. Not complaining, promise, just confused! |
|
@rebornix would you mind reviewing this PR? It would really save us a lot of headaches with the cursor jumping to unexpected locations in the file. |
|
Thanks @ultraGentle for your contribution! I tweaked the code a bit and merged into master, should be available in Insiders later this week. |
|
@rebornix My pleasure! |
|
Is this implemented? How can I enable this setting? |
|
@TheInvoker Should be as of today or tomorrow. It's been in insiders edition for a month, so just waiting for 1.49 to be released. Setting is find > "moveCursorOnType" if I remember correctly. |
|
We're finally there! 1.49.0 stable was released today with the setting Edit: Note that if you previously had |
This PR fixes #60977 and fixes #70306, both related to disorienting or disruptive cursor movement related to the Find Widget.
Description:
Enteror onclickthe prev/next arrows in the widget.Discussion:
off | highlight | move. However, when I testedoff, the behavior was just confusing, because it seemed like the Find Widget wasn't doing anything at all. Also, from searching related issues on GitHub, I haven't seen anyone asking for the "off" behavior. I thought it better not to overengineer a confusing 3rd setting that no one asked for.Further improvements:
Any feedback is welcome, and I am happy for you to revise as you see fit.
Thanks for considering!