Removed a redundand 'resolve' in SimpleFileDialog by reusing the alre…#99432
Merged
alexr00 merged 5 commits intomicrosoft:masterfrom Jun 9, 2020
Merged
Removed a redundand 'resolve' in SimpleFileDialog by reusing the alre…#99432alexr00 merged 5 commits intomicrosoft:masterfrom
alexr00 merged 5 commits intomicrosoft:masterfrom
Conversation
|
|
alexr00
reviewed
Jun 5, 2020
| let fullPath = resources.joinPath(parent, stat.name); | ||
| if (stat.isDirectory) { | ||
| fullPath = resources.addTrailingPathSeparator(fullPath, this.separator); | ||
| return { label: resources.basename(fullPath), uri: fullPath, isFolder: true, iconClasses: getIconClasses(this.modelService, this.modeService, fullPath || undefined, FileKind.FOLDER) }; |
Member
There was a problem hiding this comment.
Still should do resuorces.basename(fullPath) before the addTrailingPathSeparator since you can end up with an extra path separator.
alexr00
approved these changes
Jun 5, 2020
Member
alexr00
left a comment
alexr00
left a comment
There was a problem hiding this comment.
Good PR, thank you for improving the performance! We are currently getting ready for our May release, so I won't merge this PR immediately. Once we have branched for release I will merge it.
Contributor
Author
|
Thank you for the fast review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ady queried stat data.
This PR fixes #99384
Removed the redundant call to 'resolve' when creating items in the CimpleFileDialog by reusing the stat data already available for each item.