Allow numeric CLI argument#99540
Merged
joaomoreno merged 2 commits intomicrosoft:masterfrom Jun 8, 2020
Merged
Conversation
foad
force-pushed
the
df-98439-cli-number-only
branch
from
38a341f to
b1f7e5b
Compare
joaomoreno
requested changes
Jun 8, 2020
|
|
||
| // https://github.com/microsoft/vscode/issues/58177 | ||
| cleanedArgs._ = parsedArgs._.filter(arg => arg.length > 0); | ||
| cleanedArgs._ = parsedArgs._.filter(arg => arg.toString?.().length > 0); |
Member
There was a problem hiding this comment.
Could String(arg) be a safer option?
Contributor
Author
There was a problem hiding this comment.
Will switch it over sure 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #98439
We were discarding empty args as part of #58177, however this would discard numbers too as they were not strings when the check took place