Fixes Error Cannot read property 'id' of undefined when dragging view to Panel with no pinned views#99582
Merged
sbatten merged 2 commits intomicrosoft:masterfrom Jun 8, 2020
Merged
Conversation
sbatten
approved these changes
Jun 8, 2020
Member
|
@jeanp413 great catch, if I'm not mistaken, I think pinned composite ids is also the wrong choice, we only care about visible ids when dragging in dropping. looks good? |
Contributor
Author
|
👍 |
sbatten
approved these changes
Jun 8, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #99581