Canonicalize paths to lowercase in Windows#341
Conversation
|
This isn't handled by the code we already have for this? https://github.com/Microsoft/vscode-chrome-debug-core/blob/master/src/chrome/chromeDebugAdapter.ts#L2873 And this needs to be VS-only like the other code. |
|
I can reproduce this issue with the latest version of the debug adapter, so the existing code is not handling this case. |
|
We already have a VS-specific fix, we need to find the missing scenario and use that same fix. If someone uses the wrong case in VS Code, then they should fix that. |
|
By same fix: Do you mean enabling this code only if _caseSensitivePaths is set to true? |
|
Yeah, but you shouldn't have to check that inside this utils method. The existing fix should handle all paths coming and going from the adapter. |
|
What is your concern with putting this logic inside the utils method? My concern with trying to handle all paths coming and going from the adapter is that if we miss one, then we have a bug. It seems more reliable to me to put this logic on the util method, so even if we add new ways (or miss old ones) for paths to come and go from the debug adapter, everything will work fine. |
2 participants
Canonicalize paths to lowercase in Windows
In some cases the webroot that VS sends doesn't match the case of the file paths that VS sends for the breakpoints: ("c:\users\username\source\repos\WebApplication77\WebApplication77" vs "c:\Users\username\source\repos\WebApplication77\WebApplication77\Scripts\bootstrap.js"). That results in breakpoints not being hit in those cases.