Make this generator work with require.resolve#179
Merged
aeschli merged 1 commit intomicrosoft:masterfrom Jul 30, 2019
TomasHubelbauer:patch-1
Merged
Make this generator work with require.resolve#179aeschli merged 1 commit intomicrosoft:masterfrom TomasHubelbauer:patch-1
aeschli merged 1 commit intomicrosoft:masterfrom
TomasHubelbauer:patch-1
Conversation
I followed [Integrating Yeoman](https://yeoman.io/authoring/integrating-yeoman.html) to learn how to run a generator programatically and noticed the code example there doesn't work with the VS Code generator. See yeoman/environment#116. I worked around this by using `path.join(__dirname, 'node_modules/generator-code/generators/app/index.js')`, but I think there is no harm down in making this compatible with the guide. I believe this should do it.
Collaborator
|
Thanks @TomasHubelbauer |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I followed Integrating Yeoman to learn how to run a generator programatically and noticed the code example there doesn't work with the VS Code generator. See yeoman/environment#116.
I worked around this by using
path.join(__dirname, 'node_modules/generator-code/generators/app/index.js'), but I think there is no harm down in making this compatible with the guide.I believe this should do it.