Launch browser with argument user-data-dir specified without directory junction.#1656
Merged
connor4312 merged 1 commit intomicrosoft:mainfrom Apr 13, 2023
Merged
Launch browser with argument user-data-dir specified without directory junction.#1656connor4312 merged 1 commit intomicrosoft:mainfrom
connor4312 merged 1 commit intomicrosoft:mainfrom
Conversation
connor4312
reviewed
Apr 12, 2023
| try { | ||
| fs.mkdirSync(this.storagePath); | ||
| } catch (e) {} | ||
| if (!fs.existsSync(this.storagePath)) { |
Member
There was a problem hiding this comment.
The if checks should not be necessary for recursive mkdirSync
Contributor
Author
There was a problem hiding this comment.
Agree, I have confirmed by testing that error EEXIST can be thrown by mkdirSync only when not recursive, so existsSync is unnecessary.
That commit has been amended.
… NOT work if USER_DATA_DIR comes as or with any parent as directory junction, which may fail Microsoft Edge DevTools.
connor4312
approved these changes
Apr 13, 2023
aeschli
approved these changes
Apr 13, 2023
Member
|
Belated thanks for the PR! Unfortunately release notes have already been cut for this iteration, but you'll be in the "thank you" section in the next release at the end of this month / beginning of next |
NotAndOr
added a commit
to NotAndOr/microsoft.vscode-js-debug
that referenced
this pull request
Jun 27, 2024
NotAndOr
added a commit
to NotAndOr/microsoft.vscode-js-debug
that referenced
this pull request
Jun 27, 2024
NotAndOr
added a commit
to NotAndOr/microsoft.vscode-js-debug
that referenced
this pull request
Jun 27, 2024
NotAndOr
added a commit
to NotAndOr/microsoft.vscode-js-debug
that referenced
this pull request
Jun 27, 2024
NotAndOr
added a commit
to NotAndOr/microsoft.vscode-js-debug
that referenced
this pull request
Aug 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It fixes #1633 on OS Windows, let me know if there is some introduced impact not taken into my account, for example some unanticipated side effect on OS other than Windows.