Add defaultBehavior response to onPrepareRename#1161
Merged
dbaeumer merged 3 commits intomicrosoft:mainfrom Jan 12, 2023
wkillerud:fix/default-behavior-return-type
Merged
Add defaultBehavior response to onPrepareRename#1161dbaeumer merged 3 commits intomicrosoft:mainfrom wkillerud:fix/default-behavior-return-type
dbaeumer merged 3 commits intomicrosoft:mainfrom
wkillerud:fix/default-behavior-return-type
Conversation
dbaeumer
approved these changes
Jan 11, 2023
aeschli
approved these changes
Jan 11, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The feature works fine, but TypeScript is unaware that the response is allowed. Sync with
protocol.ts:vscode-languageserver-node/protocol/src/common/protocol.ts
Line 3623 in c91c2f8
Background: microsoft/vscode#85157 (comment)