Detect and copy npm-shirkwrap file if present#193
Merged
dbaeumer merged 3 commits intomicrosoft:masterfrom May 5, 2017
XVincentX:master
Merged
Detect and copy npm-shirkwrap file if present#193dbaeumer merged 3 commits intomicrosoft:masterfrom XVincentX:master
dbaeumer merged 3 commits intomicrosoft:masterfrom
XVincentX:master
Conversation
|
@XVincentX, |
1 similar comment
|
@XVincentX, |
Member
|
Great idea. |
Member
|
@XVincentX I reviewed the code and a couple of comments:
|
Member
Author
|
@dbaeumer You were right on both comments. I should have fixed these now. |
Member
|
Thanks. Will merge. |
Member
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR, when a shrinkwrap file is provided as
argv[5]and this exist, will make sure that file gets copied so I can lock down my dependencies in both client and server installations and have a 100% reproducible environment in my local development experience.This should become a best practise, worth mentioning in the documentation.