Add CodeActionOptions with providedCodeActionKinds#385
Merged
dbaeumer merged 1 commit intomicrosoft:masterfrom Aug 21, 2018
Gama11:codeActionOptions
Merged
Add CodeActionOptions with providedCodeActionKinds#385dbaeumer merged 1 commit intomicrosoft:masterfrom Gama11:codeActionOptions
dbaeumer merged 1 commit intomicrosoft:masterfrom
Gama11:codeActionOptions
Conversation
This was referenced Jul 28, 2018
Member
|
@Gama11 you forgot the dynamic registration and that a feature needs to keep the state per registration and can't almost never have a single global state. I will do the changes. You might want to look at them for the next PR :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See here for the motivation: microsoft/language-server-protocol#389 (comment)
Corresponding language-server-protocol PR: microsoft/language-server-protocol#534