Expose restartTimes to client.#658
Merged
dbaeumer merged 4 commits intomicrosoft:masterfrom Sep 1, 2020
Merged
Conversation
dbaeumer
requested changes
Aug 17, 2020
client/src/common/client.ts
Outdated
| private readonly restarts: number[]; | ||
|
|
||
| constructor(private name: string) { | ||
| constructor(private name: string, private restartTimes: number) { |
Member
There was a problem hiding this comment.
I would suggest to name this maxRestartCount. We usually use count instead of times for this.
dbaeumer
requested changes
Aug 18, 2020
client/src/common/client.ts
Outdated
| interface ConnectionOptions { | ||
| cancellationStrategy: CancellationStrategy | ||
| restartTimes: number | ||
| maxRestartCount: number |
Member
There was a problem hiding this comment.
Actually more stuff. Sorry for this. For backwards compatibility this should be in the whole call sequence be optional.
client/src/common/client.ts
Outdated
|
|
||
| public createDefaultErrorHandler(restartTimes: number): ErrorHandler { | ||
| return new DefaultErrorHandler(this._name, restartTimes); | ||
| public createDefaultErrorHandler(maxRestartCount: number): ErrorHandler { |
dbaeumer
requested changes
Aug 18, 2020
client/src/common/client.ts
Outdated
| public createDefaultErrorHandler(maxRestartCount: number): ErrorHandler { | ||
| return new DefaultErrorHandler(this._name, maxRestartCount); | ||
| public createDefaultErrorHandler(maxRestartCount?: number): ErrorHandler { | ||
| return new DefaultErrorHandler(this._name, maxRestartCount || 5); |
Member
There was a problem hiding this comment.
This is not correct. It will even default to 5 if maxRestartCount is 0 since || is coercive. Did you mean maxRestartCount ?? 5
Contributor
Author
There was a problem hiding this comment.
Thanks! Ah, right, ?? is what I meant.
Also added a sanity check for invalid value, It should keep the original behavior now.
- || => ?? - add sanity check for invalid value - correct the logic
|
|
agniutkarsh
approved these changes
Aug 27, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements #418