Skip to content

Add DebugAdapterNamedPipeServer factory#46

Merged
weinand merged 1 commit intomicrosoft:masterfrom
TylerLeonhardt:add-debug-adapter-named-pipe-server
Aug 19, 2020
Merged

Add DebugAdapterNamedPipeServer factory#46
weinand merged 1 commit intomicrosoft:masterfrom
TylerLeonhardt:add-debug-adapter-named-pipe-server

Conversation

@TylerLeonhardt
Copy link
Member

@TylerLeonhardt TylerLeonhardt commented Jul 26, 2020

This adds the new DebugAdapter descriptor, DebugAdapterNamedPipeServer, Added in microsoft/vscode#103210.

This will fail to compile until that is in and released via @types/vscode so I'll leave it as a Draft PR.

I tested this by:

  • Opening vscode-mock-debug in my local build of vscode that has DebugAdapterNamedPipeServer available
  • Changing runMode to the added namedPipeServer
  • Debugging a readme.md file

Let me know if there are tests I should add for this.

@weinand weinand self-assigned this Jul 27, 2020
@weinand weinand added this to the August 2020 milestone Aug 3, 2020
@weinand weinand marked this pull request as ready for review August 19, 2020 10:49
@weinand weinand merged commit 4bef24d into microsoft:master Aug 19, 2020
@weinand
Copy link
Contributor

weinand commented Aug 19, 2020

@TylerLeonhardt thanks for the PR.
I've tried it with Insiders and it works fine.
I've merged and released the PR but commented it out until VS Code 1.49 is out.

@TylerLeonhardt TylerLeonhardt deleted the add-debug-adapter-named-pipe-server branch August 19, 2020 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants