Merged
Conversation
Co-authored-by: alexr00 <[email protected]>
…orrectly The constructor was incorrectly initializing _compareBranch to baseBranch instead of the actual compareBranch parameter. This caused the file diff comparison to potentially use wrong branches before setCompareBranch completed its async initialization, resulting in displaying the wrong list of files when creating a PR. Co-authored-by: alexr00 <[email protected]>
Copilot
AI
changed the title
[WIP] Fix wrong list of files when creating PR
Fix wrong file list when creating PR
Feb 3, 2026
alexr00
approved these changes
Feb 4, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the bug where the "Create Pull Request" view initially showed the wrong list of changed files until the base branch was toggled.
Changes:
- Initialize
CreatePullRequestDataModel._compareBranchwith thecompareBranchargument instead ofbaseBranch, ensuring the initial diff and state listener reference the correct compare branch. - Keep the async
setCompareBranchinitialization and repository state listener behavior intact, so subsequent updates still rely on the correct compare branch.
aiday-mar
approved these changes
Feb 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When creating a new PR, the wrong list of files was displayed. Switching the base branch and back would show the correct files.
Root Cause
CreatePullRequestDataModelconstructor initialized_compareBranchtobaseBranchinstead ofcompareBranch:This caused the file diff to use incorrect branches before
setCompareBranch()completed async initialization, and the repository state listener to check against the wrong branch.Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
update.code.visualstudio.com/opt/hostedtoolcache/node/20.20.0/x64/bin/node node ./out/src/test/runTests.js(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.