Add githubBranch flag to control the branch for GitHub relative links#474
Merged
joaomoreno merged 3 commits intomicrosoft:masterfrom Aug 11, 2020
JeffreyCA:jeffreyca/github-branch
Merged
Add githubBranch flag to control the branch for GitHub relative links#474joaomoreno merged 3 commits intomicrosoft:masterfrom JeffreyCA:jeffreyca/github-branch
joaomoreno merged 3 commits intomicrosoft:masterfrom
JeffreyCA:jeffreyca/github-branch
Conversation
joaomoreno
requested changes
Aug 9, 2020
joaomoreno
requested changes
Aug 10, 2020
Member
There was a problem hiding this comment.
Now you've gone too far. Please remove all the changes to package.json and yarn.lock as they don't seem necessary.
Edit: oh I missed your comment. No, I'd rather we keep TypeScript locked and just use the ternary operation. Sorry for that! Can you revert and simply keep the test addition?
joaomoreno
approved these changes
Aug 11, 2020
Member
|
Thanks! 🎆 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #468
Currently if
repositoryinpackage.jsonis set to a GitHub URL, all the relative links inREADME.mdget converted to absolute links but they always refer to themasterbranch. This change adds a flaggithubBranchwhich allows the user to override this assumption without having to use to overridebaseImagesUrlandbaseContentUrl.The
baseImageUrlandbaseContentUrloptions take precedence overgithubBranch, so doing something like:vsce --githubBranch main --baseImagesUrl http://blahwill only change non-image relative links to stem from themain.