Fix connection reset error on long sessions#123
Merged
jaredmixpanel merged 1 commit intomixpanel:masterfrom Mar 8, 2024
Merged
Fix connection reset error on long sessions#123jaredmixpanel merged 1 commit intomixpanel:masterfrom
jaredmixpanel merged 1 commit intomixpanel:masterfrom
Conversation
HTTPAdatper mounted onto requests.Session using the 'http' prefix which is always superseded by already existing 'https://'. Effectively, the current code will not retry the mixpanel POST request and will cause a connection reset error.
trobertsonsf
approved these changes
Jan 31, 2024
trobertsonsf
left a comment
trobertsonsf
left a comment
There was a problem hiding this comment.
Thank you! This has been spamming our logs for a while.
Contributor
Author
|
@trobertsonsf Thank you for the approval. Can you merge the PR? |
jaredmixpanel
approved these changes
Mar 8, 2024
Contributor
jaredmixpanel
left a comment
jaredmixpanel
left a comment
There was a problem hiding this comment.
Thank you, sorry this didn't get merged sooner.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix issue of connection reset error.
HTTPAdatper created that allows retrying POST requests is mounted onto requests.Session using the 'http' prefix. This prefix is always superseded by already existing 'https://' which re-raises on POST and fails the request.