small CRITs update and maxmind#94
Merged
krmaxwell merged 5 commits intomlsecproject:masterfrom Dec 17, 2014
Merged
Conversation
added 2 commits
December 16, 2014 23:05
Member
|
Hey, Paul! Thanks for the script and fix! Do you mind separating out the globe visualizer part on a different PR? If was to add maps support to combine, I would be partial to https://github.com/hrbrmstr/pewpew ;) |
Contributor
Author
|
my bad - i should have done the globe on another branch |
Contributor
Author
|
there you go! Sorry about that - i thought git would have taken a snapshot of the code when i issued the PR - now i know to use branches |
Member
|
Heh, thanks! When you have a PR for the globe thing we can discuss that further. |
Member
|
Thanks for the assist @technoskald ! |
Member
|
💪 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small updates to the list of error codes to allow for older CRITs versions (include accepting 400 status codes).
Furthermore, added a script to download the maxmind databases (should take care of #24)?