[WIP] Fix swarm init and swarm update test#37442
Closed
cyli wants to merge 1 commit intomoby:masterfrom
cyli:fix-init-with-external-ca-test
Closed
[WIP] Fix swarm init and swarm update test#37442cyli wants to merge 1 commit intomoby:masterfrom cyli:fix-init-with-external-ca-test
cyli wants to merge 1 commit intomoby:masterfrom
cyli:fix-init-with-external-ca-test
Conversation
the external CA correctly propagates the CA certificate along with the external CA URL. Update the tests to reflect that. Signed-off-by: cyli <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #37442 +/- ##
=========================================
Coverage ? 34.95%
=========================================
Files ? 610
Lines ? 44875
Branches ? 0
=========================================
Hits ? 15685
Misses ? 27070
Partials ? 2120 |
This was referenced Jul 12, 2018
Contributor
Author
|
Note this is failing currently because it is a CLI test in moby/moby, which needs to be moved/migrated to cli/e2e or some such. I'll label this WIP for now. Alternately, these will pass if we bump the CLI version we test against in moby/moby to 18.06 once it's released. |
cyli
changed the title
derek
bot
added
the
status/failing-ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
docker/cli#1178 changed the CLI behavior so that the external CA correctly propagates the CA certificate along with the external CA URL. Update the tests to reflect that.
cc @andrewhsu