Conversation
distribution/pull_v2.go
Outdated
There was a problem hiding this comment.
Happy to change message to whatever...
thaJeztah
added
area/distribution
distribution/errors.go
Outdated
There was a problem hiding this comment.
Should it continue looping, or pick the first error? I recall we had some code similar in https://github.com/moby/moby/blob/master/errdefs/http_helpers.go#L157 which was based on code from the distribution packages
There was a problem hiding this comment.
I don't see why we wouldn't look at all the returned errors in this case.
|
Let's make sure |
|
@tiborvass It's not, however the error message wasn't quite right since we always set the "error after falling back" regardless if we fell back at all. |
cpuguy83
force-pushed
the
fallback_manifest_store
branch
from
15249d1 to
ae44307
Compare
|
@tianon @tiborvass good to go? |
distribution/pull_v2.go
Outdated
There was a problem hiding this comment.
typo in specification. Also wonder if we should point out what's missing in the spec. https://github.com/docker/distribution/blob/master/docs/spec/api.md#pulling-an-image
Some registries seem to be non-conformant and return a not found error when pulling by digest (which docker now does all the time). To work around this, fallback when all of the following are true: 1. Image reference is a tag 2. Tag->digest resolution succeeds 3. Fetch by resolved digest fails with a "not found" error. This is intentionally not caching the manifests to reduce complexity for this edge case. Signed-off-by: Brian Goff <[email protected]>
cpuguy83
force-pushed
the
fallback_manifest_store
branch
from
ae44307 to
495d623
Compare
5 participants
Some registries seem to be non-conformant and return a not found error
when pulling by digest (which docker now does all the time).
To work around this, fallback when all of the following are true:
This is intentionally not caching the manifests to reduce complexity for
this edge case.
Closes #41687