Dockerfile: update test-registry to v2.8.1 (latest release) by thaJeztah · Pull Request #42889 · moby/moby

thaJeztah · 2021-09-27T12:20:31Z

follow-up to #42881. Updating the version of the registry caused tests to fail, so moving it to a separate PR to dive into what's causing those failures (and if there's possibly an actual issue; either a bug or an issue in how we use the registry for testing)

- A picture of a cute animal (not mandatory but encouraged)

thaJeztah · 2021-09-27T13:33:51Z

Yup, looks to be failing on many tests. From the output of those tests, it seems the registry is not starting correctly, or somehow not listening on the expected port/ip

=== RUN   TestPluginInstall/no_auth
time="2021-09-27T12:34:19Z" level=warning msg="reference for unknown type: application/vnd.docker.plugin.v1+json"
time="2021-09-27T12:34:19Z" level=warning msg="reference for unknown type: application/vnd.docker.plugin.v1+json" digest="sha256:4b25d06088389b568a1412379bcd2818a63b14ec1a76056f61af72ac1df53c4b" mediatype=application/vnd.docker.plugin.v1+json size=522
time="2021-09-27T12:34:19Z" level=warning msg="reference for unknown type: application/vnd.docker.plugin.v1+json"
time="2021-09-27T12:34:19Z" level=warning msg="reference for unknown type: application/vnd.docker.plugin.v1+json" digest="sha256:4b25d06088389b568a1412379bcd2818a63b14ec1a76056f61af72ac1df53c4b" mediatype=application/vnd.docker.plugin.v1+json size=522
    plugin_test.go:77: assertion failed: error is not nil: error pushing plugin: error pushing plugin: failed to do request: Head "https://127.0.0.1:5000/v2/test-testplugininstall/no_auth/blobs/sha256:4b25d06088389b568a1412379bcd2818a63b14ec1a76056f61af72ac1df53c4b": dial tcp 127.0.0.1:5000: connect: connection refused
    --- FAIL: TestPluginInstall/no_auth (1.60s)

tianon · 2021-11-08T23:28:03Z

Can we reproduce locally? (I'm not at all familiar with these tests 🙈)

It would probably help to try and get logs from the registry instance to see what's going wrong. 😅

thaJeztah · 2022-02-18T20:15:16Z

Rebased this one, and changed it to v2.8.0, which was now released. Lots of failures still, related to the `` mediatype:

=== RUN   TestPluginInstall/no_auth
time="2022-02-18T01:10:22Z" level=warning msg="reference for unknown type: application/vnd.docker.plugin.v1+json"
time="2022-02-18T01:10:22Z" level=warning msg="reference for unknown type: application/vnd.docker.plugin.v1+json" digest="sha256:6d9537ed87d8d0b2e437d8c92c4650c9aa78f0490dbb92d87394e0543a903195" mediatype=application/vnd.docker.plugin.v1+json size=522
time="2022-02-18T01:10:22Z" level=warning msg="reference for unknown type: application/vnd.docker.plugin.v1+json"
time="2022-02-18T01:10:22Z" level=warning msg="reference for unknown type: application/vnd.docker.plugin.v1+json" digest="sha256:6d9537ed87d8d0b2e437d8c92c4650c9aa78f0490dbb92d87394e0543a903195" mediatype=application/vnd.docker.plugin.v1+json size=522
    plugin_test.go:77: assertion failed: error is not nil: error pushing plugin: error pushing plugin: failed to do request: Head "https://127.0.0.1:5000/v2/test-testplugininstall/no_auth/blobs/sha256:e54fa740429f77dfb439821ebc805b26857e264962a926bd46a934a87f81c3d0": dial tcp 127.0.0.1:5000: connect: connection refused
    --- FAIL: TestPluginInstall/no_auth (1.53s)

I'm wondering why it's logging the same warning twice (but perhaps one of them was a HEAD or GET request?)

time="2022-02-18T01:10:22Z" level=warning msg="reference for unknown type: application/vnd.docker.plugin.v1+json"
time="2022-02-18T01:10:22Z" level=warning msg="reference for unknown type: application/vnd.docker.plugin.v1+json" digest="sha256:6d9537ed87d8d0b2e437d8c92c4650c9aa78f0490dbb92d87394e0543a903195" mediatype=application/vnd.docker.

That warning is coming from https://github.com/containerd/containerd/blob/v1.5.9/remotes/handlers.go#L73-L86, and it looks like that's all hard-coded (wondering if the containerd code should have a way to register custom mediaTypes)

However, those are "just" warnings? The actual error in the test above looks to be that we're unable to connect (or that the registry is refusing the plugin mediatype);

plugin_test.go:77: assertion failed: error is not nil: error pushing plugin: error pushing plugin: failed to do request: Head "https://127.0.0.1:5000/v2/test-testplugininstall/no_auth/blobs/sha256:e54fa740429f77dfb439821ebc805b26857e264962a926bd46a934a87f81c3d0": dial tcp 127.0.0.1:5000: connect: connection refused
--- FAIL: TestPluginInstall/no_auth (1.53s)

Version 2.8.0 does have (at least a const) for the mediatype though; https://github.com/distribution/distribution/blob/v2.8.0/manifest/schema2/manifest.go#L20-L21
Version 2.3.0 (what we were using before this) did not appear to have that mediatype; https://github.com/distribution/distribution/blob/v2.3.0/manifest/schema2/manifest.go#L13-L23

Looking at the 2.8.0 code; it looks like there's a concept of classes that can be allowed or denied https://github.com/distribution/distribution/blob/v2.8.0/registry/handlers/manifests.go#L432-L433

That option was added in v2.7 (through distribution/distribution@e02278f), but
gets configured through imh.App.Config.Policy.Repository.Classes. However if no classes are configured, it should not enforce those restrictions:
https://github.com/distribution/distribution/blob/v2.8.0/registry/handlers/manifests.go#L419-L422

Ok, so looks like further digging may be needed.

thaJeztah · 2022-02-18T20:17:13Z

oh! just realised that registry 2.8.0 now comes in all architectures, so we no longer have to build it from source (can just COPY --from). Let me update the dockerfile for that as well

thaJeztah · 2022-02-18T20:22:35Z

... and ... I guess I just noticed what may be related when looking at that;

        && git clone https://github.com/docker/distribution.git . \
        && git checkout -q "$REGISTRY_VERSION" \
        && GOPATH="/go/src/github.com/docker/distribution/Godeps/_workspace:$GOPATH" \
           go build -buildmode=pie -o /build/registry-v2 github.com/docker/distribution/cmd/registry \

The code was still assuming Godeps/_workspace 🤦 (curious that it still built something then?)

thaJeztah · 2022-03-10T21:35:36Z

Oh; I see I didn't post that yet, but stumbled upon a PR, (had a tab still open with it); Could this failure could have to do with #42210, which was done to handle a regression (see #42191), but I'm wondering if that's causing the "reverse" effect when using a newer registry (perhaps it no longer supports that type by default, but didn't dig into that yet)

tianon · 2022-03-10T22:31:09Z

Dockerfile


+# REGISTRY_VERSION specifies the version of the registry to build and install
+# from the https://github.com/docker/distribution repository. This version of
+# the registry is used to test both schema 1 and schema 2 manifests. Generally,


This isn't totally accurate anymore, right? (There's a separate version used below for schema 1)

Signed-off-by: Sebastiaan van Stijn <[email protected]>

The official registry 2.8.1 image now comes with all architectures that we're interested in, so we can just copy the binary from that image instead of building it from source: docker buildx imagetools inspect registry:2.8.1 | grep Platform Platform: linux/amd64 Platform: linux/arm/v6 Platform: linux/arm/v7 Platform: linux/arm64/v8 Platform: linux/ppc64le Platform: linux/s390x Signed-off-by: Sebastiaan van Stijn <[email protected]>

thaJeztah added area/distribution Image Distribution status/2-code-review area/testing labels Sep 27, 2021

thaJeztah mentioned this pull request Jan 19, 2022

GitHub Actions e2e tests docker/cli#3320

Merged

thaJeztah force-pushed the update_test_registry branch from 74b6376 to c25d96f Compare February 18, 2022 00:55

thaJeztah changed the title ~~Dockerfile: update test-registry to v2.7.1 (latest release)~~ Dockerfile: update test-registry to v2.8.0 (latest release) Feb 18, 2022

thaJeztah force-pushed the update_test_registry branch 2 times, most recently from d926a08 to 0d33996 Compare February 18, 2022 22:45

thaJeztah force-pushed the update_test_registry branch from 0d33996 to 15b89fb Compare March 10, 2022 21:41

thaJeztah changed the title ~~Dockerfile: update test-registry to v2.8.0 (latest release)~~ Dockerfile: update test-registry to v2.8.1 (latest release) Mar 10, 2022

tianon reviewed Mar 10, 2022

View reviewed changes

thaJeztah mentioned this pull request Apr 21, 2022

plugin: add EndpointResolver interface #43358

Merged

thaJeztah added 2 commits August 26, 2022 20:12

Dockerfile: update test-registry to v2.8.1 (latest release)

6a15e50

Signed-off-by: Sebastiaan van Stijn <[email protected]>

thaJeztah force-pushed the update_test_registry branch from 15b89fb to 8ca4f5b Compare August 26, 2022 18:12

thaJeztah mentioned this pull request Aug 24, 2023

test: update registry version to latest #46307

Merged

rumpl mentioned this pull request Aug 24, 2023

test/integration: Download the registry binary #46312

Merged

thaJeztah closed this in #46312 Aug 24, 2023

thaJeztah deleted the update_test_registry branch January 27, 2025 22:18

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Dockerfile: update test-registry to v2.8.1 (latest release)#42889

Dockerfile: update test-registry to v2.8.1 (latest release)#42889
thaJeztah wants to merge 2 commits intomoby:masterfrom
thaJeztah:update_test_registry

thaJeztah commented Sep 27, 2021 •

edited

Loading

Uh oh!

thaJeztah commented Sep 27, 2021

Uh oh!

tianon commented Nov 8, 2021

Uh oh!

thaJeztah commented Feb 18, 2022

Uh oh!

thaJeztah commented Feb 18, 2022

Uh oh!

thaJeztah commented Feb 18, 2022

Uh oh!

thaJeztah commented Mar 10, 2022

Uh oh!

tianon Mar 10, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

thaJeztah commented Sep 27, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

thaJeztah commented Sep 27, 2021

Uh oh!

tianon commented Nov 8, 2021

Uh oh!

thaJeztah commented Feb 18, 2022

Uh oh!

thaJeztah commented Feb 18, 2022

Uh oh!

thaJeztah commented Feb 18, 2022

Uh oh!

thaJeztah commented Mar 10, 2022

Uh oh!

tianon Mar 10, 2022

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

thaJeztah commented Sep 27, 2021 •

edited

Loading