Skip to content

Remote API#432

Merged
creack merged 81 commits intomasterfrom
remote-api
May 10, 2013
Merged

Remote API#432
creack merged 81 commits intomasterfrom
remote-api

Conversation

@shykes
Copy link
Contributor

@shykes shykes commented Apr 19, 2013

No description provided.

@shykes shykes closed this Apr 19, 2013
@shykes shykes reopened this Apr 19, 2013
@shykes
Copy link
Contributor Author

shykes commented Apr 19, 2013

Not complete yet. Please stick to high-level design discussion for now.

@titanous
Copy link
Contributor

This is completely RPC, I'd prefer something closer to the RESTish API layout that I described in #21.

@titanous
Copy link
Contributor

BTW, I'm still up for implementing the API, I just won't be able to get to it for a few weeks.

@shykes
Copy link
Contributor Author

shykes commented Apr 19, 2013

It will restify.

@bryanhelmig
Copy link

❤️

@anotherjesse
Copy link

Should this compile? I get:

# github.com/dotcloud/docker
../.gopath/src/github.com/dotcloud/docker/api.go:457: too many arguments to return
../.gopath/src/github.com/dotcloud/docker/api.go:491: undefined: name
../.gopath/src/github.com/dotcloud/docker/api.go:492: undefined: name
 ../.gopath/src/github.com/dotcloud/docker/api.go:496: undefined: name

I'm on ubuntu 12.10 with go version of

go version go1.0.2

@vieux
Copy link
Contributor

vieux commented Apr 29, 2013

@anotherjesse my bad, I forgot to push.
Keep in mind it's still WIP

@titanous
Copy link
Contributor

@vieux It looks like this is coming along nicely. Ping me when you're ready for a preliminary review.

@ghost ghost assigned vieux Apr 29, 2013
@anotherjesse
Copy link

@vieux Thanks. I'm now able to prototype my project before hack day.

I like that container post returns the container id. Is it possible to return the id without waiting for the cmd to finish?

creack added a commit that referenced this pull request May 10, 2013
+ Remote API: Implement the remote API.
@creack creack merged commit 26bfeb1 into master May 10, 2013
rtyler pushed a commit to rtyler/docker that referenced this pull request Feb 23, 2018
[INFRA-729] Correctly determine what branch are we in, again
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants