vendor: github.com/moby/buildkit v0.11.0-rc2 by thaJeztah · Pull Request #44529 · moby/moby

thaJeztah · 2022-11-24T23:03:29Z

depends on vendor: update various dependencies in preparation of BuildKit update #44527
depends on vendor: google.golang.org/grpc v1.50.1 #44528

full diff: https://github.com/moby/buildkit/compare/v0.10.6..v0.11.0-rc2

thaJeztah · 2022-11-25T00:19:37Z

Looks related to moby/buildkit@3548517

=== Errors
Error: .\build_session_test.go:98:43: cannot use []filesync.SyncedDir{…} (value of type []filesync.SyncedDir) as type filesync.DirSource in argument to filesync.NewFSSyncProvider:
[]filesync.SyncedDir does not implement filesync.DirSource (missing LookupDir method)

thaJeztah · 2022-11-25T01:08:07Z

Bunch of panics, probably related to the history changes;

=== CONT  TestFrontendIntegration/TestRefReadFile/worker=dockerd
time="2022-11-25T00:40:49Z" level=warning msg="dockerd proxy error: read unix @->/tmp/integration3110156821/d2p5n0rojbqma/docker.sock: read: connection reset by peer"
time="2022-11-25T00:41:04Z" level=warning msg="dockerd proxy error: write unix @->/tmp/integration3110156821/d2p5n0rojbqma/docker.sock: write: broken pipe"
    frontend_test.go:123: 
        	Error Trace:	/src/frontend/frontend_test.go:123
        	            				/src/frontend/run.go:86
        	            				/src/frontend/run.go:195
        	Error:      	Received unexpected error:
        	            	DeadlineExceeded: context deadline exceeded
        	            	github.com/moby/buildkit/util/stack.Enable
        	            		/src/util/stack/stack.go:77
        	            	github.com/moby/buildkit/util/grpcerrors.FromGRPC
        	            		/src/util/grpcerrors/grpcerrors.go:197
        	            	github.com/moby/buildkit/util/grpcerrors.UnaryClientInterceptor
        	            		/src/util/grpcerrors/intercept.go:41
        	            	google.golang.org/grpc.(*ClientConn).Invoke
        	            		/src/vendor/google.golang.org/grpc/call.go:35
        	            	github.com/moby/buildkit/frontend/gateway/pb.(*lLBBridgeClient).Ping
        	            		/src/frontend/gateway/pb/gateway.pb.go:2855
        	            	github.com/moby/buildkit/client.(*gatewayClientForBuild).Ping
        	            		/src/client/build.go:130
        	            	github.com/moby/buildkit/frontend/gateway/grpcclient.New
        	            		/src/frontend/gateway/grpcclient/client.go:48
        	            	github.com/moby/buildkit/client.(*Client).Build.func2
        	            		/src/client/build.go:54
        	            	github.com/moby/buildkit/client.(*Client).solve.func3
        	            		/src/client/solve.go:273
        	            	golang.org/x/sync/errgroup.(*Group).Go.func1
        	            		/src/vendor/golang.org/x/sync/errgroup/errgroup.go:75
        	            	runtime.goexit
        	            		/usr/local/go/src/runtime/asm_amd64.s:1594
        	Test:       	TestFrontendIntegration/TestRefReadFile/worker=dockerd
    sandbox.go:234: stdout: /usr/bin/dockerd
    sandbox.go:234: stderr: /usr/bin/dockerd

    sandbox.go:237: panic: runtime error: invalid memory address or nil pointer dereference
    sandbox.go:237: [signal SIGSEGV: segmentation violation code=0x1 addr=0x200 pc=0x13d2718]
    sandbox.go:237: 
    sandbox.go:237: goroutine 199 [running]:
    sandbox.go:237: github.com/docker/docker/vendor/go.etcd.io/bbolt.(*DB).beginRWTx(0x0?)
    sandbox.go:237: 	/go/src/github.com/docker/docker/vendor/go.etcd.io/bbolt/db.go:634 +0x38
    sandbox.go:237: github.com/docker/docker/vendor/go.etcd.io/bbolt.(*DB).Begin(0x46e4d0?, 0x47?)
    sandbox.go:237: 	/go/src/github.com/docker/docker/vendor/go.etcd.io/bbolt/db.go:589 +0x1d
    sandbox.go:237: github.com/docker/docker/vendor/go.etcd.io/bbolt.(*DB).Update(0xc000f0edc0?, 0x2819860)
    sandbox.go:237: 	/go/src/github.com/docker/docker/vendor/go.etcd.io/bbolt/db.go:725 +0x3e
    sandbox.go:237: github.com/docker/docker/vendor/github.com/moby/buildkit/solver/llbsolver.(*HistoryQueue).init.func1()
    sandbox.go:237: 	/go/src/github.com/docker/docker/vendor/github.com/moby/buildkit/solver/llbsolver/history.go:43 +0x31
    sandbox.go:237: sync.(*Once).doSlow(0x27ccc40?, 0x0?)
    sandbox.go:237: 	/usr/local/go/src/sync/once.go:74 +0xc2
    sandbox.go:237: sync.(*Once).Do(...)
    sandbox.go:237: 	/usr/local/go/src/sync/once.go:65
    sandbox.go:237: github.com/docker/docker/vendor/github.com/moby/buildkit/solver/llbsolver.(*HistoryQueue).init(0xc000b7a420?)
    sandbox.go:237: 	/go/src/github.com/docker/docker/vendor/github.com/moby/buildkit/solver/llbsolver/history.go:42 +0x5b
    sandbox.go:237: github.com/docker/docker/vendor/github.com/moby/buildkit/solver/llbsolver.(*HistoryQueue).Update(0xc00074d940, {0x2844be0, 0xc000b8bfb0}, 0xc000b7a600)
    sandbox.go:237: 	/go/src/github.com/docker/docker/vendor/github.com/moby/buildkit/solver/llbsolver/history.go:66 +0x65
    sandbox.go:237: github.com/docker/docker/vendor/github.com/moby/buildkit/solver/llbsolver.(*Solver).Solve(0xc00092d380, {0x2844be0, 0xc000b8bfb0}, {0xc00005f1e0, 0x19}, {0xc00005f220, 0x19}, {0x0, 0x0, {0x0, ...}, ...}, ...)
    sandbox.go:237: 	/go/src/github.com/docker/docker/vendor/github.com/moby/buildkit/solver/llbsolver/solver.go:143 +0x24c
    sandbox.go:237: github.com/docker/docker/vendor/github.com/moby/buildkit/control.(*Controller).Solve(0xc000880300, {0x2844be0, 0xc000b8bfb0}, 0xc000b8d9e0)
    sandbox.go:237: 	/go/src/github.com/docker/docker/vendor/github.com/moby/buildkit/control/control.go:382 +0xfe5
    sandbox.go:237: github.com/docker/docker/vendor/github.com/moby/buildkit/api/services/control._Control_Solve_Handler.func1({0x2844be0, 0xc000b8bfb0}, {0x27b9440?, 0xc000b8d9e0})
    sandbox.go:237: 	/go/src/github.com/docker/docker/vendor/github.com/moby/buildkit/api/services/control/control.pb.go:2242 +0x78
    sandbox.go:237: github.com/docker/docker/vendor/github.com/moby/buildkit/util/grpcerrors.UnaryServerInterceptor({0x2844be0?, 0xc000b8bfb0?}, {0x27b9440?, 0xc000b8d9e0?}, 0xc000f67a20?, 0x24c0c20?)
    sandbox.go:237: 	/go/src/github.com/docker/docker/vendor/github.com/moby/buildkit/util/grpcerrors/intercept.go:14 +0x3d
    sandbox.go:237: github.com/docker/docker/vendor/github.com/moby/buildkit/api/services/control._Control_Solve_Handler({0x2727720?, 0xc000880300}, {0x2844be0, 0xc000b8bfb0}, 0xc0007ae3f0, 0x2819928)
    sandbox.go:237: 	/go/src/github.com/docker/docker/vendor/github.com/moby/buildkit/api/services/control/control.pb.go:2244 +0x138
    sandbox.go:237: github.com/docker/docker/vendor/google.golang.org/grpc.(*Server).processUnaryRPC(0xc0009a4b40, {0x2853da0, 0xc000a7ec60}, 0xc000b8d440, 0xc000b224e0, 0x3949658, 0x0)
    sandbox.go:237: 	/go/src/github.com/docker/docker/vendor/google.golang.org/grpc/server.go:1340 +0xd23
    sandbox.go:237: github.com/docker/docker/vendor/google.golang.org/grpc.(*Server).handleStream(0xc0009a4b40, {0x2853da0, 0xc000a7ec60}, 0xc000b8d440, 0x0)
    sandbox.go:237: 	/go/src/github.com/docker/docker/vendor/google.golang.org/grpc/server.go:1713 +0xa2f
    sandbox.go:237: github.com/docker/docker/vendor/google.golang.org/grpc.(*Server).serveStreams.func1.2()
    sandbox.go:237: 	/go/src/github.com/docker/docker/vendor/google.golang.org/grpc/server.go:965 +0x98
    sandbox.go:237: created by github.com/docker/docker/vendor/google.golang.org/grpc.(*Server).serveStreams.func1
    sandbox.go:237: 	/go/src/github.com/docker/docker/vendor/google.golang.org/grpc/server.go:963 +0x28a
    sandbox.go:237: > stopped 2022-11-25 00:40:49.908189885 +0000 UTC m=+1.406050459 exit status 2 2
=== CONT  TestFrontendIntegration/TestRefEvaluate/worker=dockerd
time="2022-11-25T00:41:23Z" level=warning msg="dockerd proxy error: write unix @->/tmp/integration3823752418/dgf9bkvs9tinz/docker.sock: use of closed network connection"
    frontend_test.go:341: 
        	Error Trace:	/src/frontend/frontend_test.go:341
        	            				/src/frontend/run.go:86
        	            				/src/frontend/run.go:195
        	Error:      	Received unexpected error:
        	            	DeadlineExceeded: context deadline exceeded
        	            	github.com/moby/buildkit/util/stack.Enable
        	            		/src/util/stack/stack.go:77
        	            	github.com/moby/buildkit/util/grpcerrors.FromGRPC
        	            		/src/util/grpcerrors/grpcerrors.go:197
        	            	github.com/moby/buildkit/util/grpcerrors.UnaryClientInterceptor
        	            		/src/util/grpcerrors/intercept.go:41
        	            	google.golang.org/grpc.(*ClientConn).Invoke
        	            		/src/vendor/google.golang.org/grpc/call.go:35
        	            	github.com/moby/buildkit/frontend/gateway/pb.(*lLBBridgeClient).Ping
        	            		/src/frontend/gateway/pb/gateway.pb.go:2855
        	            	github.com/moby/buildkit/client.(*gatewayClientForBuild).Ping
        	            		/src/client/build.go:130
        	            	github.com/moby/buildkit/frontend/gateway/grpcclient.New
        	            		/src/frontend/gateway/grpcclient/client.go:48
        	            	github.com/moby/buildkit/client.(*Client).Build.func2
        	            		/src/client/build.go:54
        	            	github.com/moby/buildkit/client.(*Client).solve.func3
        	            		/src/client/solve.go:273
        	            	golang.org/x/sync/errgroup.(*Group).Go.func1
        	            		/src/vendor/golang.org/x/sync/errgroup/errgroup.go:75
        	            	runtime.goexit
        	            		/usr/local/go/src/runtime/asm_amd64.s:1594
        	Test:       	TestFrontendIntegration/TestRefEvaluate/worker=dockerd
    sandbox.go:234: stdout: /usr/bin/dockerd
    sandbox.go:234: stderr: /usr/bin/dockerd

    sandbox.go:237: panic: runtime error: invalid memory address or nil pointer dereference
    sandbox.go:237: [signal SIGSEGV: segmentation violation code=0x1 addr=0x200 pc=0x13d2718]
    sandbox.go:237: 
    sandbox.go:237: goroutine 176 [running]:
    sandbox.go:237: github.com/docker/docker/vendor/go.etcd.io/bbolt.(*DB).beginRWTx(0x0?)
    sandbox.go:237: 	/go/src/github.com/docker/docker/vendor/go.etcd.io/bbolt/db.go:634 +0x38
    sandbox.go:237: github.com/docker/docker/vendor/go.etcd.io/bbolt.(*DB).Begin(0x46e4d0?, 0x47?)
    sandbox.go:237: 	/go/src/github.com/docker/docker/vendor/go.etcd.io/bbolt/db.go:589 +0x1d
    sandbox.go:237: github.com/docker/docker/vendor/go.etcd.io/bbolt.(*DB).Update(0xc00012e960?, 0x2819860)
    sandbox.go:237: 	/go/src/github.com/docker/docker/vendor/go.etcd.io/bbolt/db.go:725 +0x3e
    sandbox.go:237: github.com/docker/docker/vendor/github.com/moby/buildkit/solver/llbsolver.(*HistoryQueue).init.func1()
    sandbox.go:237: 	/go/src/github.com/docker/docker/vendor/github.com/moby/buildkit/solver/llbsolver/history.go:43 +0x31
    sandbox.go:237: sync.(*Once).doSlow(0x27ccc40?, 0x0?)
    sandbox.go:237: 	/usr/local/go/src/sync/once.go:74 +0xc2
    sandbox.go:237: sync.(*Once).Do(...)
    sandbox.go:237: 	/usr/local/go/src/sync/once.go:65
    sandbox.go:237: github.com/docker/docker/vendor/github.com/moby/buildkit/solver/llbsolver.(*HistoryQueue).init(0xc000c9cae0?)
    sandbox.go:237: 	/go/src/github.com/docker/docker/vendor/github.com/moby/buildkit/solver/llbsolver/history.go:42 +0x5b
    sandbox.go:237: github.com/docker/docker/vendor/github.com/moby/buildkit/solver/llbsolver.(*HistoryQueue).Update(0xc000cbbac0, {0x2844be0, 0xc000c9c0f0}, 0xc000c9cc30)
    sandbox.go:237: 	/go/src/github.com/docker/docker/vendor/github.com/moby/buildkit/solver/llbsolver/history.go:66 +0x65
    sandbox.go:237: github.com/docker/docker/vendor/github.com/moby/buildkit/solver/llbsolver.(*Solver).Solve(0xc000e13f80, {0x2844be0, 0xc000c9c0f0}, {0xc000b76700, 0x19}, {0xc000b76720, 0x19}, {0x0, 0x0, {0x0, ...}, ...}, ...)
    sandbox.go:237: 	/go/src/github.com/docker/docker/vendor/github.com/moby/buildkit/solver/llbsolver/solver.go:143 +0x24c
    sandbox.go:237: github.com/docker/docker/vendor/github.com/moby/buildkit/control.(*Controller).Solve(0xc00016dc80, {0x2844be0, 0xc000c9c0f0}, 0xc001125320)
    sandbox.go:237: 	/go/src/github.com/docker/docker/vendor/github.com/moby/buildkit/control/control.go:382 +0xfe5
    sandbox.go:237: github.com/docker/docker/vendor/github.com/moby/buildkit/api/services/control._Control_Solve_Handler.func1({0x2844be0, 0xc000c9c0f0}, {0x27b9440?, 0xc001125320})
    sandbox.go:237: 	/go/src/github.com/docker/docker/vendor/github.com/moby/buildkit/api/services/control/control.pb.go:2242 +0x78
    sandbox.go:237: github.com/docker/docker/vendor/github.com/moby/buildkit/util/grpcerrors.UnaryServerInterceptor({0x2844be0?, 0xc000c9c0f0?}, {0x27b9440?, 0xc001125320?}, 0xc00008da20?, 0x24c0c20?)
    sandbox.go:237: 	/go/src/github.com/docker/docker/vendor/github.com/moby/buildkit/util/grpcerrors/intercept.go:14 +0x3d
    sandbox.go:237: github.com/docker/docker/vendor/github.com/moby/buildkit/api/services/control._Control_Solve_Handler({0x2727720?, 0xc00016dc80}, {0x2844be0, 0xc000c9c0f0}, 0xc000845c70, 0x2819928)
    sandbox.go:237: 	/go/src/github.com/docker/docker/vendor/github.com/moby/buildkit/api/services/control/control.pb.go:2244 +0x138
    sandbox.go:237: github.com/docker/docker/vendor/google.golang.org/grpc.(*Server).processUnaryRPC(0xc000842960, {0x2853da0, 0xc000f34bd0}, 0xc0011246c0, 0xc000edd500, 0x3949658, 0x0)
    sandbox.go:237: 	/go/src/github.com/docker/docker/vendor/google.golang.org/grpc/server.go:1340 +0xd23
    sandbox.go:237: github.com/docker/docker/vendor/google.golang.org/grpc.(*Server).handleStream(0xc000842960, {0x2853da0, 0xc000f34bd0}, 0xc0011246c0, 0x0)
    sandbox.go:237: 	/go/src/github.com/docker/docker/vendor/google.golang.org/grpc/server.go:1713 +0xa2f
    sandbox.go:237: github.com/docker/docker/vendor/google.golang.org/grpc.(*Server).serveStreams.func1.2()
    sandbox.go:237: 	/go/src/github.com/docker/docker/vendor/google.golang.org/grpc/server.go:965 +0x98
    sandbox.go:237: created by github.com/docker/docker/vendor/google.golang.org/grpc.(*Server).serveStreams.func1
    sandbox.go:237: 	/go/src/github.com/docker/docker/vendor/google.golang.org/grpc/server.go:963 +0x28a
    sandbox.go:237: > stopped 2022-11-25 00:41:13.201819894 +0000 UTC m=+24.699680368 exit status 2 2
=== CONT  TestFrontendIntegration/TestReturnNil/worker=dockerd
time="2022-11-25T00:41:46Z" level=warning msg="dockerd proxy error: write unix @->/tmp/integration180467734/drwrmfma57bim/docker.sock: use of closed network connection"
    frontend_test.go:51: 
        	Error Trace:	/src/frontend/frontend_test.go:51
        	            				/src/frontend/run.go:86
        	            				/src/frontend/run.go:195
        	Error:      	Received unexpected error:
        	            	DeadlineExceeded: context deadline exceeded
        	            	github.com/moby/buildkit/util/stack.Enable
        	            		/src/util/stack/stack.go:77
        	            	github.com/moby/buildkit/util/grpcerrors.FromGRPC
        	            		/src/util/grpcerrors/grpcerrors.go:197
        	            	github.com/moby/buildkit/util/grpcerrors.UnaryClientInterceptor
        	            		/src/util/grpcerrors/intercept.go:41
        	            	google.golang.org/grpc.(*ClientConn).Invoke
        	            		/src/vendor/google.golang.org/grpc/call.go:35
        	            	github.com/moby/buildkit/frontend/gateway/pb.(*lLBBridgeClient).Ping
        	            		/src/frontend/gateway/pb/gateway.pb.go:2855
        	            	github.com/moby/buildkit/client.(*gatewayClientForBuild).Ping
        	            		/src/client/build.go:130
        	            	github.com/moby/buildkit/frontend/gateway/grpcclient.New
        	            		/src/frontend/gateway/grpcclient/client.go:48
        	            	github.com/moby/buildkit/client.(*Client).Build.func2
        	            		/src/client/build.go:54
        	            	github.com/moby/buildkit/client.(*Client).solve.func3
        	            		/src/client/solve.go:273
        	            	golang.org/x/sync/errgroup.(*Group).Go.func1
        	            		/src/vendor/golang.org/x/sync/errgroup/errgroup.go:75
        	            	runtime.goexit
        	            		/usr/local/go/src/runtime/asm_amd64.s:1594
        	Test:       	TestFrontendIntegration/TestReturnNil/worker=dockerd
    sandbox.go:234: stdout: /usr/bin/dockerd
    sandbox.go:234: stderr: /usr/bin/dockerd

thaJeztah · 2022-12-15T14:57:22Z

vendor.mod

+
+// FIXME(thaJeztah): remove this replace once we can; see https://github.com/moby/buildkit/pull/3410 and https://github.com/spdx/tools-golang/pull/174
+replace github.com/spdx/tools-golang => github.com/jedevc/spdx-tools-golang v0.0.0-20221205121515-6fe9d226281a


Looks like we need a replace rule, pending spdx/tools-golang#174 (see moby/buildkit#3410)

thaJeztah · 2022-12-15T14:59:03Z

vendor.mod

 	github.com/hashicorp/go-msgpack v0.5.5 // indirect
 	github.com/hashicorp/go-sockaddr v1.0.2 // indirect
 	github.com/hashicorp/golang-lru v0.5.4 // indirect
+	github.com/in-toto/in-toto-golang v0.3.4-0.20220709202702-fa494aaa0add // indirect


Opened moby/buildkit#3415, but it looks like BuildKit depends on things that are not compatible with current releases.

full diff: tonistiigi/fsutil@9ed6126...0127568 Signed-off-by: Sebastiaan van Stijn <[email protected]>

full diff: https://github.com/moby/buildkit/compare/v0.10.6..v0.11.0-rc2 Signed-off-by: Sebastiaan van Stijn <[email protected]>

thaJeztah added area/builder Build status/2-code-review impact/changelog area/builder/buildkit Build labels Nov 24, 2022

thaJeztah added this to the v-next milestone Nov 24, 2022

thaJeztah force-pushed the bump_buildkit3 branch from 797c081 to 04a38aa Compare November 24, 2022 23:45

thaJeztah force-pushed the bump_buildkit3 branch from 04a38aa to 6415e70 Compare November 25, 2022 00:25

thaJeztah force-pushed the bump_buildkit3 branch 4 times, most recently from 5888ae1 to da9e370 Compare November 30, 2022 16:29

thaJeztah force-pushed the bump_buildkit3 branch 2 times, most recently from d6aa1ce to be804ba Compare December 9, 2022 20:34

thaJeztah changed the title ~~vendor: github.com/moby/buildkit v0.11.0-rc1~~ vendor: github.com/moby/buildkit v0.11.0-rc2 Dec 15, 2022

thaJeztah force-pushed the bump_buildkit3 branch from be804ba to cfd4271 Compare December 15, 2022 14:43

thaJeztah commented Dec 15, 2022

View reviewed changes

thaJeztah added 2 commits December 15, 2022 21:45

vendor: github.com/tonistiigi/fsutil v0.0.0-20221114235510-0127568185cf

64adde5

full diff: tonistiigi/fsutil@9ed6126...0127568 Signed-off-by: Sebastiaan van Stijn <[email protected]>

vendor: github.com/moby/buildkit v0.11.0-rc2

3284e13

full diff: https://github.com/moby/buildkit/compare/v0.10.6..v0.11.0-rc2 Signed-off-by: Sebastiaan van Stijn <[email protected]>

thaJeztah force-pushed the bump_buildkit3 branch from cfd4271 to 3284e13 Compare December 15, 2022 20:48

tonistiigi mentioned this pull request Dec 22, 2022

vendor: update buildkit to v0.11.2 #44686

Merged

cpuguy83 closed this in #44686 Feb 2, 2023

thaJeztah deleted the bump_buildkit3 branch February 2, 2023 21:48

thaJeztah removed area/builder Build status/2-code-review impact/changelog area/builder/buildkit Build labels May 15, 2023

thaJeztah removed this from the 24.0.0 milestone May 15, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

vendor: github.com/moby/buildkit v0.11.0-rc2#44529

vendor: github.com/moby/buildkit v0.11.0-rc2#44529
thaJeztah wants to merge 2 commits intomoby:masterfrom
thaJeztah:bump_buildkit3

thaJeztah commented Nov 24, 2022 •

edited

Loading

Uh oh!

thaJeztah commented Nov 25, 2022

Uh oh!

thaJeztah commented Nov 25, 2022

Uh oh!

thaJeztah Dec 15, 2022

Uh oh!

thaJeztah Dec 15, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant


		// FIXME(thaJeztah): remove this replace once we can; see https://github.com/moby/buildkit/pull/3410 and https://github.com/spdx/tools-golang/pull/174
		replace github.com/spdx/tools-golang => github.com/jedevc/spdx-tools-golang v0.0.0-20221205121515-6fe9d226281a

Conversation

thaJeztah commented Nov 24, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

thaJeztah commented Nov 25, 2022

Uh oh!

thaJeztah commented Nov 25, 2022

Uh oh!

thaJeztah Dec 15, 2022

Choose a reason for hiding this comment

Uh oh!

thaJeztah Dec 15, 2022

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

thaJeztah commented Nov 24, 2022 •

edited

Loading