Skip to content

Dockerfile/shell: Install buildx cli plugin#44957

Closed
vvoland wants to merge 1 commit intomoby:masterfrom
vvoland:dockerfile-buildx
Closed

Dockerfile/shell: Install buildx cli plugin#44957
vvoland wants to merge 1 commit intomoby:masterfrom
vvoland:dockerfile-buildx

Conversation

@vvoland
Copy link
Contributor

@vvoland vvoland commented Feb 8, 2023

Installs the buildx cli plugin in the container shell by default. Previously user had to manually download the buildx binary to use buildkit.

Note: The default cli in shell is v17.06 (🧓🏻), so you still need to provide a more recent cli that's actually able to use the buildx plugin:

make DOCKER_BUILD_ARGS='--build-arg=DOCKERCLI_VERSION=v20.10.23' shell

or

make DOCKER_CLI_PATH=<your custom build cli binary> shell

Signed-off-by: Paweł Gronowski [email protected]

- What I did
Made buildx available by default in dev shell container.

- How I did it
Install buildx binary from docker/buildx-bin image.

- How to verify it

$ make DOCKER_BUILD_ARGS='--build-arg=DOCKERCLI_VERSION=v20.10.23' shell
...
root@58a62b814982:/go/src/github.com/docker/docker# docker buildx version
github.com/docker/buildx v0.10.2 00ed17df6d20f3ca4553d45789264cdb78506e5f

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

Installs the buildx cli plugin in the container shell by default.
Previously user had to manually download the buildx binary to use
buildkit.

Signed-off-by: Paweł Gronowski <[email protected]>
@vvoland vvoland added the kind/enhancement Enhancements are not bugs or new features but can improve usability or performance. label Feb 8, 2023
@vvoland vvoland added this to the v-next milestone Feb 8, 2023
@thaJeztah
Copy link
Member

Silly question; what's buildx used for inside the dev container, or is this intended to be used for e2e tests?

As to the docker CLI, we should look at a "fixed version" (if needed) CLI for the old integration-cli tests, and possibly a more current version for the dev container.

@neersighted
Copy link
Member

neersighted commented Feb 8, 2023

I was wishing for buildx the other day -- I had to manually install it to use our dind environment to test some of the BuildKit-related regressions. Can we block this on splitting the build environment to have both a frozen CLI for integration tests & a current build of the CLI for interactive/debugging use?

@vvoland
Copy link
Contributor Author

vvoland commented Feb 8, 2023

@thaJeztah I use it for building images with buildkit (containerd integration only supports buildkit for now) in container shell. It isn't used by any build process/testing.

@neersighted Can work on that, looks fun 😄

@rumpl rumpl modified the milestones: 24.0.0, v-future Apr 24, 2023
@vvoland vvoland closed this Jun 5, 2023
@vvoland vvoland removed this from the v-future milestone Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/enhancement Enhancements are not bugs or new features but can improve usability or performance. status/2-code-review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants