Skip to content

vendor: containerd 2.0 / buildkit v0.19.0 dependencies#49274

Merged
AkihiroSuda merged 11 commits intomoby:masterfrom
thaJeztah:containerd_2_deps
Jan 15, 2025
Merged

vendor: containerd 2.0 / buildkit v0.19.0 dependencies#49274
AkihiroSuda merged 11 commits intomoby:masterfrom
thaJeztah:containerd_2_deps

Conversation

@thaJeztah
Copy link
Member

@thaJeztah thaJeztah commented Jan 14, 2025

vendor: github.com/AdaLogics/go-fuzz-headers v0.0.0-20240806141605-e8a1dd7889d6

full diff: AdaLogics/go-fuzz-headers@e8a1dd7...e8a1dd7

vendor: github.com/AdamKorcz/go-118-fuzz-build v0.0.0-20231105174938-2b5cbb29f3e2

full diff: AdamKorcz/go-118-fuzz-build@8075edf...2b5cbb2

vendor: github.com/containerd/errdefs v1.0.0

no changes in vendored code

full diff: containerd/errdefs@v0.3.0...v1.0.0

vendor: github.com/containerd/ttrpc v1.2.5

full diff: containerd/ttrpc@v1.2.5...v1.2.7

vendor: github.com/containerd/go-cni v1.1.11

full diff: containerd/go-cni@v1.1.10...v1.1.11

vendor: github.com/containernetworking/cni v1.2.3

full diff: containernetworking/cni@v1.2.2...v1.2.3

vendor: github.com/vbatts/tar-split v0.11.6

full diff: vbatts/tar-split@v0.11.5...v0.11.6

vendor: github.com/fsnotify/fsnotify v1.7.0

full diff: fsnotify/fsnotify@v1.6.0...v1.7.0

vendor: k8s.io/klog/v2 v2.130.1

full diff: kubernetes/klog@v2.90.1...v2.130.1

vendor: github.com/stretchr/testify v1.10.0

full diff: stretchr/testify@v1.9.0...v1.10.0

vendor: github.com/Microsoft/hcsshim v0.12.9

full diff: microsoft/hcsshim@v0.12.8...v0.12.9

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

@thaJeztah
Copy link
Member Author

Ah! Looks like I need that Remove otel workaround test commit as well; 8875d6a

=== Failed
=== FAIL: cmd/dockerd TestOtelMeterLeak (0.64s)
    daemon_test.go:303: Allocations: 3
    daemon_test.go:307: Allocations count decreased. OTEL leak workaround is no longer needed!

@thaJeztah thaJeztah marked this pull request as draft January 14, 2025 11:00
@thaJeztah thaJeztah marked this pull request as ready for review January 14, 2025 16:32
@thaJeztah
Copy link
Member Author

Hm.. looks like containerd/platforms changed a regex, and that's included in the error-message, which makes buildkit tests fail;

=== FAIL: frontend/dockerfile TestIntegration/TestUndeclaredArg/worker=dockerd/frontend=builtin/warntype=progress#07 (0.02s)
    dockerfile_lint_test.go:1645: 
        	Error Trace:	/src/frontend/dockerfile/dockerfile_lint_test.go:1572
        	            				/src/frontend/dockerfile/dockerfile_lint_test.go:1645
        	Error:      	Error message not equal:
        	            	expected: "failed to solve: failed to parse platform linux/${MYARCH}: \"\" is an invalid component of \"linux/\": platform specifier component must match \"^[A-Za-z0-9_-]+$\": invalid argument (did you mean MY_ARCH?)"
        	            	actual  : "failed to solve: failed to parse platform linux/${MYARCH}: \"\" is an invalid component of \"linux/\": platform specifier component must match \"^[A-Za-z0-9_.-]+$\": invalid argument (did you mean MY_ARCH?)"
        	Test:       	TestIntegration/TestUndeclaredArg/worker=dockerd/frontend=builtin/warntype=progress#07
        --- FAIL: TestIntegration/TestUndeclaredArg/worker=dockerd/frontend=builtin/warntype=progress#07 (0.02s)

=== FAIL: frontend/dockerfile TestIntegration/TestUndeclaredArg/worker=dockerd/frontend=builtin/warntype=unmarshal#07 (0.02s)
    dockerfile_lint_test.go:1478: 
        	Error Trace:	/src/frontend/dockerfile/dockerfile_lint_test.go:1478
        	            				/src/frontend/gateway/grpcclient/client.go:215
        	            				/src/client/build.go:58
        	            				/src/client/solve.go:295
        	            				/src/vendor/golang.org/x/sync/errgroup/errgroup.go:78
        	            				/usr/local/go/src/runtime/asm_amd64.s:1700
        	Error:      	Not equal: 
        	            	expected: "failed to parse platform linux/${MYARCH}: \"\" is an invalid component of \"linux/\": platform specifier component must match \"^[A-Za-z0-9_-]+$\": invalid argument (did you mean MY_ARCH?)"

@AkihiroSuda AkihiroSuda merged commit 1cf2cb5 into moby:master Jan 15, 2025
@thaJeztah thaJeztah deleted the containerd_2_deps branch January 15, 2025 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants