Skip to content

vendor: github.com/moby/buildkit v0.20.0-rc3#49486

Closed
thaJeztah wants to merge 1 commit intomoby:masterfrom
thaJeztah:bump_buildkit_rc3
Closed

vendor: github.com/moby/buildkit v0.20.0-rc3#49486
thaJeztah wants to merge 1 commit intomoby:masterfrom
thaJeztah:bump_buildkit_rc3

Conversation

@thaJeztah
Copy link
Member

@thaJeztah thaJeztah commented Feb 18, 2025

Testing 0.20_backport_rc3 branch from moby/buildkit#5755

vendor: github.com/moby/buildkit v0.20.0-rc3

full diff: moby/buildkit@v0.20.0-rc3...v0.20.0-rc3

- Human readable description for the release notes

- A picture of a cute animal (not mandatory but encouraged)

@crazy-max
Copy link
Member

crazy-max commented Feb 18, 2025

https://github.com/moby/moby/actions/runs/13391283541/job/37399399448?pr=49486#step:3:751

49.00 # github.com/docker/docker/builder/builder-next
49.00 builder/builder-next/controller.go:567:31: not enough arguments in call to cdidevices.NewManager
49.00 	have (*cdi.Cache)
49.00 	want (*cdi.Cache, []string)
62.99 + rm -f /go/src/github.com/docker/docker/go.mod

I'm looking at this one, we changed the signature so it takes a list of allowed devices from configuration related to moby/buildkit#5742. I think for moby we could have a similar configuration on daemon side.

full diff: moby/buildkit@v0.20.0-rc3...v0.20.0-rc3

Co-authored-by: CrazyMax <[email protected]>
Signed-off-by: CrazyMax <[email protected]>
Signed-off-by: Sebastiaan van Stijn <[email protected]>
@thaJeztah thaJeztah added this to the 28.0.0 milestone Feb 18, 2025
@thaJeztah thaJeztah marked this pull request as ready for review February 18, 2025 21:10
@thaJeztah thaJeztah deleted the bump_buildkit_rc3 branch February 18, 2025 22:25
@thaJeztah thaJeztah removed this from the 28.0.0 milestone Feb 18, 2025
@thaJeztah
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants