Add support for chained RequestAuthConfigs for push/pull#50341
Draft
thaJeztah wants to merge 3 commits intomoby:masterfrom
Draft
Add support for chained RequestAuthConfigs for push/pull#50341thaJeztah wants to merge 3 commits intomoby:masterfrom
thaJeztah wants to merge 3 commits intomoby:masterfrom
Conversation
thaJeztah
added
area/distribution
thaJeztah
force-pushed
the
client_auth_chain
branch
from
c6ea9b8 to
f09e432
Compare
thaJeztah
changed the title
Member
Author
|
Derp; forgot to unstash a patch. |
thaJeztah
force-pushed
the
client_auth_chain
branch
4 times, most recently
from
1c97553 to
e069187
Compare
thaJeztah
force-pushed
the
client_auth_chain
branch
from
e069187 to
c4b261b
Compare
This was referenced Jul 11, 2025
thaJeztah
force-pushed
the
client_auth_chain
branch
4 times, most recently
from
ed3557f to
07a86dd
Compare
Signed-off-by: Sebastiaan van Stijn <[email protected]>
This utility allows chaining privilegeFuncs to try multiple options for authentication. Signed-off-by: Sebastiaan van Stijn <[email protected]>
PrivilegeFunc was added in [18472] as an alternative to passing static authentication. The default was still to try the static authentication before calling the PrivilegeFunc (if present). For now, we need to keep this behavior, as PrivilegeFunc may be an interactive prompt, however, we should change this to only use static auth if not empty. Ultimately, we should deprecate its use in favor of callers providing a PrivilegeFunc (which can be chained), or a list of PrivilegeFuncs. [18472]: moby@e78f02c Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
force-pushed
the
client_auth_chain
branch
from
07a86dd to
a4871ed
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
client: implement chainPrivilegeFuncs utility
This utility allows chaining privilegeFuncs to try multiple options for authentication.
Add support for chained RequestAuthConfigs for push/pull
PrivilegeFunc was added in 18472 as an alternative to passing static
authentication. The default was still to try the static authentication
before calling the PrivilegeFunc (if present).
For now, we need to keep this behavior, as PrivilegeFunc may be an
interactive prompt, however, we should change this to only use static
auth if not empty. Ultimately, we should deprecate its use in favor of
callers providing a PrivilegeFunc (which can be chained), or a list of
PrivilegeFuncs.
- What I did
- How I did it
- How to verify it
- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)