client/pkg/jsonmessage: make DisplayJSONMessages accept a iter.Seq2#52062
Merged
thaJeztah merged 1 commit intomoby:masterfrom Feb 23, 2026
Merged
client/pkg/jsonmessage: make DisplayJSONMessages accept a iter.Seq2#52062thaJeztah merged 1 commit intomoby:masterfrom
thaJeztah merged 1 commit intomoby:masterfrom
Conversation
thaJeztah
added
status/2-code-review
kind/enhancement
The `DisplayJSONMessages` only accepted a `JSONMessagesStream`. This meant that it would not accept the output from (for example) [client.ImagePushResponse]. This patch: - Makes `DisplayJSONMessages` accept any `iter.Seq2[jsonstream.Message, error]` - Makes `JSONMessagesStream` an alias instead of a concrete type (TBD if we actually need the type). - Some minor cleanups in the implementation. [client.ImagePushResponse]: https://github.com/moby/moby/blob/fa87120ae64a170fd42096de3b873b439b95016b/client/image_push.go#L20-L24 Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
force-pushed
the
stream_eazy
branch
from
90d65c5 to
8b4edd7
Compare
There was a problem hiding this comment.
Pull request overview
This PR makes the DisplayJSONMessages function more flexible by accepting any iter.Seq2[jsonstream.Message, error] instead of only the JSONMessagesStream type. This enables the function to work directly with outputs from methods like ImagePushResponse.JSONMessages() without requiring type conversion.
Changes:
- Changed
JSONMessagesStreamfrom a defined type to a type alias foriter.Seq2[jsonstream.Message, error] - Updated
DisplayJSONMessagessignature to acceptiter.Seq2[jsonstream.Message, error]directly - Removed explicit type declaration in
DisplayJSONMessagesStream(line 154) as it's now unnecessary with the type alias
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
client/pkg/jsonmessage/jsonmessage.go |
Changed JSONMessagesStream to type alias, updated DisplayJSONMessages to accept iter.Seq2 directly, simplified type declaration in DisplayJSONMessagesStream |
vendor/github.com/moby/moby/client/pkg/jsonmessage/jsonmessage.go |
Identical changes to the vendored version of the package |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
robmry
approved these changes
Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
DisplayJSONMessagesonly accepted aJSONMessagesStream. This meant that it would not accept the output from (for example) client.ImagePushResponse.This patch:
DisplayJSONMessagesaccept anyiter.Seq2[jsonstream.Message, error]JSONMessagesStreaman alias instead of a concrete type (TBD if we actually need the type).- What I did
- How I did it
- How to verify it
- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)