daemon: send systemd READY=1 after API serve loops start#52077
Merged
thaJeztah merged 1 commit intomoby:masterfrom Feb 23, 2026
Merged
daemon: send systemd READY=1 after API serve loops start#52077thaJeztah merged 1 commit intomoby:masterfrom
thaJeztah merged 1 commit intomoby:masterfrom
Conversation
robmry
reviewed
Feb 23, 2026
The daemon previously signaled systemd (READY=1) before the API Serve loops were started. Move the readiness notification until after the API listeners are serving to reduce the window where systemd considers the daemon ready but the HTTP accept loop has not yet started. While modifying, also use `WaitGroup.Go` for a slight cleanup. Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
force-pushed
the
notify_readier
branch
from
795867d to
99add78
Compare
robmry
approved these changes
Feb 23, 2026
vvoland
approved these changes
Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The daemon previously signaled systemd (READY=1) before the API Serve loops were started.
Move the readiness notification until after the API listeners are serving to reduce the window where systemd considers the daemon ready but the HTTP accept loop has not yet started.
- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)