Skip to content

Fix swagger/OpenAPI return value specification for /system/df endpoint.#52124

Merged
vvoland merged 4 commits intomoby:masterfrom
chemodax:patch-1
Mar 5, 2026
Merged

Fix swagger/OpenAPI return value specification for /system/df endpoint.#52124
vvoland merged 4 commits intomoby:masterfrom
chemodax:patch-1

Conversation

@chemodax
Copy link
Contributor

@chemodax chemodax commented Mar 1, 2026

Fix swagger/OpenAPI return value specification for /system/df endpoint.

chemodax added 4 commits March 1, 2026 21:28
Fix return value definition for /system/df endpoint:
ImagesDiskUsage -> ImageUsage
ContainersDiskUsage -> ContainerUsage
VolumesDiskUsage -> VolumeUsage
BuildCacheDiskUsage -> BuildCacheUsage

These names match actual names returned from dockerd.

Signed-off-by: chemodax <[email protected]>
@chemodax chemodax changed the title Patch 1 Fix swagger/OpenAPI return value specification for /system/df endpoint. Mar 1, 2026
Copy link
Contributor

@vvoland vvoland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

type DiskUsage struct {
ImageUsage *image.DiskUsage `json:"ImageUsage,omitempty"`
ContainerUsage *container.DiskUsage `json:"ContainerUsage,omitempty"`
VolumeUsage *volume.DiskUsage `json:"VolumeUsage,omitempty"`
BuildCacheUsage *build.DiskUsage `json:"BuildCacheUsage,omitempty"`
}

@vvoland vvoland added this to the 29.3.0 milestone Mar 5, 2026
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vvoland vvoland merged commit c0625f2 into moby:master Mar 5, 2026
169 of 173 checks passed
@chemodax chemodax deleted the patch-1 branch March 5, 2026 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants