Skip to content

Add AOT compatibility publish test#1246

Merged
stephentoub merged 8 commits intomainfrom
copilot/add-aot-publish-test
Feb 9, 2026
Merged

Add AOT compatibility publish test#1246
stephentoub merged 8 commits intomainfrom
copilot/add-aot-publish-test

Conversation

Copy link
Contributor

Copilot AI commented Feb 5, 2026 •
edited
Loading

  • Create tests/ModelContextProtocol.AotCompatibility.TestApp/ console app project with PublishAot=true that references all three library projects
  • Create Program.cs with client-server sanity test using in-memory pipes (Echo tool round-trip)
  • Add the new project to ModelContextProtocol.slnx solution file
  • Add AOT publish test step to CI workflow (ci-build-test.yml)
  • Add test-aot Makefile target for quick local testing
  • Update test-aot to also run the published AOT binary and verify it succeeds
  • Verify the project builds successfully (0 warnings, 0 errors)
  • Verify dotnet publish with AOT succeeds without warnings
  • Verify AOT-published binary runs the full client-server round-trip and outputs "Success!"
  • Run code review and security checks (0 issues found)
Original prompt

This section details on the original issue you should resolve

<issue_title>Enable AOT Publish Test</issue_title>
<issue_description>In order to ensure this library works with native AOT, we should have a test as described in https://devblogs.microsoft.com/dotnet/creating-aot-compatible-libraries/#analyzing-.net-libraries. We currently have the Roslyn Analzyers enabled, but the analyzers unfortunately can't catch all issues.

We can follow other repos implementations for this. A good starting point would be

https://github.com/dotnet/extensions/tree/main/test/Libraries/Microsoft.Extensions.AotCompatibility.TestApp

https://github.com/dotnet/extensions/blob/799a1db854dac00e51b0765bdd6cd3494b4b6b5d/eng/pipelines/templates/BuildAndTest.yml#L119-L121</issue_description>

<agent_instructions>Please add a test project like @eerhardt mentions.</agent_instructions>

Comments on the Issue (you are @copilot in this section)

@stephentoub > +1. This it really needed for my [Unity-MCP](https://github.com/IvanMurzak/Unity-MCP) server to let it work in runtime games to let developer to write commands in their games directly.

This issue is about adding a test.

What problem are you hitting? </comment_new>
<comment_new>@eiriktsarpalis
Might be worth mentioning that TUnit is another potential AOT ready testing library we could use to easily set up AOT testing.</comment_new>

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

@stephentoub
Add AOT compatibility test app project
794092b 
Add a console application that references all three library packages
(ModelContextProtocol.Core, ModelContextProtocol, ModelContextProtocol.AspNetCore)
and is published with PublishAot=true. This ensures that any AOT/trimming
warnings from the libraries are caught during CI, following the pattern from
dotnet/extensions.

Co-authored-by: stephentoub <[email protected]>
Copilot AI changed the title [WIP] Add AOT publish test for library compatibility Add AOT compatibility publish test Feb 5, 2026
Copilot AI requested a review from stephentoub February 5, 2026 21:09
stephentoub
stephentoub reviewed Feb 5, 2026
View reviewed changes
@stephentoub
Update AOT test app with client-server sanity test
ceaf0a3 
Replace the minimal "Success!" print with a full client-server round-trip
test using in-memory pipes, matching the InMemoryTransport sample pattern.
The test creates a server with an Echo tool, connects a client, lists tools,
invokes the Echo tool, and verifies the result.

Co-authored-by: stephentoub <[email protected]>
Copilot AI requested a review from stephentoub February 5, 2026 21:30
@stephentoub stephentoub marked this pull request as ready for review February 6, 2026 02:01
@stephentoub
Copy link
Contributor

stephentoub commented Feb 6, 2026

CI successfully ran the publishing test:
image

@stephentoub stephentoub enabled auto-merge (squash) February 6, 2026 02:14
eiriktsarpalis
eiriktsarpalis reviewed Feb 9, 2026
View reviewed changes
Copy link
Member

@eiriktsarpalis eiriktsarpalis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stephentoub I have had success using TUnit for Native AOT smoke testing in my personal projects. It lets you execute the code and assertions on the AOT runtime and you can exercise multiple scenaria because they're written as standard unit tests.

eerhardt
eerhardt approved these changes Feb 9, 2026
View reviewed changes
Copy link

@eerhardt eerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just had 1 comment. The rest of the changes look good.

@stephentoub
Copy link
Contributor

stephentoub commented Feb 9, 2026

@stephentoub I have had success using TUnit for Native AOT smoke testing in my personal projects. It lets you execute the code and assertions on the AOT runtime and you can exercise multiple scenaria because they're written as standard unit tests.

We could look at doing something more in the future. For now, I'm happy to just do what we do elsewhere.

eiriktsarpalis
eiriktsarpalis reviewed Feb 9, 2026
View reviewed changes
eiriktsarpalis
eiriktsarpalis previously approved these changes Feb 9, 2026
View reviewed changes
auto-merge was automatically disabled February 9, 2026 17:38

Head branch was pushed to by a user without write access

Copilot AI requested a review from eiriktsarpalis February 9, 2026 17:39
eerhardt
eerhardt reviewed Feb 9, 2026
View reviewed changes
@stephentoub
Copy link
Contributor

stephentoub commented Feb 9, 2026

@copilot please update the makefile to verify that the published app prints "Success!" and that its exit code is 0

Copy link
Contributor Author

Copilot AI commented Feb 9, 2026

@copilot please update the makefile to verify that the published app prints "Success!" and that its exit code is 0

Done in 806a918. The test-aot target now captures the app's output to a file (failing if exit code is non-zero), then verifies the output contains "Success!" via grep -q.

@stephentoub
Copy link
Contributor

stephentoub commented Feb 9, 2026

@copilot remove the grep

@stephentoub stephentoub enabled auto-merge (squash) February 9, 2026 19:38
@stephentoub stephentoub merged commit 9c1538f into main Feb 9, 2026
9 of 10 checks passed
@stephentoub stephentoub deleted the copilot/add-aot-publish-test branch February 9, 2026 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eiriktsarpalis eiriktsarpalis eiriktsarpalis approved these changes

@stephentoub stephentoub Awaiting requested review from stephentoub

+1 more reviewer

@eerhardt eerhardt eerhardt approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@stephentoub stephentoub

Copilot code review Copilot

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Enable AOT Publish Test

4 participants

@stephentoub @eiriktsarpalis @eerhardt