Use package-lock.json to pin conformance test dependencies#1247
Merged
Use package-lock.json to pin conformance test dependencies#1247
Conversation
halter73
force-pushed
the
halter73/pin-client
branch
from
92a1909 to
2ad7489
Compare
Contributor
Author
|
I updated the repo to include a package-lock.json and updated the conformance tests to call npm install if necessary and avoid npx so we always use what's in the lock file. That should keep things reliable on the CI and for local development. |
halter73
changed the title
jeffhandley
previously approved these changes
Feb 6, 2026
tests/ModelContextProtocol.AspNetCore.Tests/ClientConformanceTests.cs
Outdated
Show resolved
Hide resolved
…Info - Revert accidental change to non-Windows NpmStartInfo logic
stephentoub
approved these changes
Feb 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@modelcontextprotocol/[email protected]added a new guard inProtocol.connect()that throws "Already connected to a transport" which older versions of the client conformance tests don't account for.Example failure: https://github.com/modelcontextprotocol/csharp-sdk/actions/runs/21724253697/job/62680470772?pr=1245