Add serialization roundtrip tests for all Protocol namespace types#1289
Merged
stephentoub merged 9 commits intomainfrom Feb 17, 2026
Merged
Add serialization roundtrip tests for all Protocol namespace types#1289stephentoub merged 9 commits intomainfrom
stephentoub merged 9 commits intomainfrom
Conversation
Add test files for Annotations, Argument, CallToolRequestParams, CallToolResult, CancelledNotificationParams, ClientCapabilities, CompleteRequestParams, CompleteResult, Completion, and ElicitResult. Each test file covers full property round-trip serialization including inherited base class properties (Meta, NextCursor, Cursor) and minimal property scenarios. Co-authored-by: Copilot <[email protected]>
Add 10 test files covering serialization round-trip for: - ElicitRequestParams - GetPromptRequestParams - GetPromptResult - InitializeRequestParams - InitializeResult - JsonRpcError - ListPromptsResult - ListResourcesResult - ListResourceTemplatesResult - ListRootsResult Co-authored-by: Copilot <[email protected]>
Add test coverage for ListToolsResult, LoggingMessageNotificationParams, ModelPreferences, ModelHint, PromptArgument, PromptMessage, ReadResourceRequestParams, ReadResourceResult, ResourceTemplate, ResourceUpdatedNotificationParams, and Root protocol types. Each test file covers round-trip serialization with both full and minimal property sets, including inherited base class properties. Co-authored-by: Copilot <[email protected]>
Add 8 new test files for protocol type serialization: - ServerCapabilitiesTests.cs - SetLevelRequestParamsTests.cs - SubscribeRequestParamsTests.cs - ToolAnnotationsTests.cs - UnsubscribeRequestParamsTests.cs - UrlElicitationRequiredErrorDataTests.cs - CreateTaskResultTests.cs - ElicitationCompleteNotificationParamsTests.cs Co-authored-by: Copilot <[email protected]>
Add 10 new test files covering CompleteContext, ListPromptsRequestParams, ListResourcesRequestParams, ListResourceTemplatesRequestParams, ListToolsRequestParams, ListRootsRequestParams, PingRequestParams, PingResult, EmptyResult, and InitializedNotificationParams. Co-authored-by: Copilot <[email protected]>
…lity types Add 10 new test files covering serialization for: - ResourceListChangedNotificationParams - RootsListChangedNotificationParams - PromptListChangedNotificationParams - ToolListChangedNotificationParams - SamplingCapability - RootsCapability - PromptsCapability - ResourcesCapability - ToolsCapability - ElicitationCapability Co-authored-by: Copilot <[email protected]>
Copilot
AI
changed the title
[WIP] Add tests for all public types in protocols namespace
Add serialization roundtrip tests for all Protocol namespace types
Feb 16, 2026
stephentoub
approved these changes
Feb 16, 2026
Contributor
stephentoub
left a comment
stephentoub
left a comment
There was a problem hiding this comment.
@copilot if there are existing tests specific to the types these new test files are associated with, those tests should be moved to the right file
- Move Tool InputSchema tests from ProtocolTypeTests.cs to ToolTests.cs - Move McpTask sub-type tests from McpTaskTests.cs into 11 new dedicated files: McpTaskStatusNotificationParamsTests, GetTaskRequestParamsTests, GetTaskResultTests, CancelMcpTaskRequestParamsTests, CancelMcpTaskResultTests, ListTasksRequestParamsTests, ListTasksResultTests, GetTaskPayloadRequestParamsTests, McpTasksCapabilityTests, RequestMcpTasksCapabilityTests, McpTaskMetadataTests Co-authored-by: Copilot <[email protected]>
Replace weak Assert.NotNull(deserialized.Meta) assertions with proper content validation in all 40 Protocol test files. Each assertion now verifies the actual key-value pair set in the test's Meta property. Co-authored-by: Copilot <[email protected]>
Contributor
Author
Done in 7fcde12. Moved Tool InputSchema tests from |
halter73
approved these changes
Feb 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.