Skip to content

Add explicit [Experimental] protected constructors to McpClient and McpServer#1363

Merged
stephentoub merged 5 commits intomainfrom
copilot/add-explicit-protected-constructors
Feb 24, 2026
Merged

Add explicit [Experimental] protected constructors to McpClient and McpServer#1363
stephentoub merged 5 commits intomainfrom
copilot/add-explicit-protected-constructors

Conversation

Copy link
Contributor

Copilot AI commented Feb 23, 2026

Adds explicit protected constructors annotated with [Experimental(MCPEXP002)] to the abstract McpClient and McpServer base classes, making subclassing an explicitly experimental operation. Introduces a new MCPEXP002 diagnostic ID distinct from the existing MCPEXP001 (Tasks/Extensions), with its URL pointing to this pull request. Suppresses the MCPEXP002 diagnostic in internal implementation classes (McpClientImpl, McpServerImpl, DestinationBoundMcpServer) and a test class (TestServerForIChatClient) that derive from them. Documents MCPEXP002 in docs/list-of-diagnostics.md.


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

@stephentoub stephentoub added the breaking-change This issue or PR introduces a breaking change label Feb 23, 2026
Copy link
Contributor

@stephentoub stephentoub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also please fix the PR title and description

Copy link
Contributor Author

Copilot AI commented Feb 23, 2026

Also please fix the PR title and description

Updated in ff5e1dc. I'm unable to change the PR title directly — could you update it to "Add explicit [Experimental] protected constructors to McpClient and McpServer"?

Copilot AI changed the title [WIP] Add explicit protected constructors in McpClient and McpServer Add explicit [Experimental] protected constructors to McpClient and McpServer Feb 23, 2026
Copilot AI requested a review from jeffhandley February 24, 2026 00:59
@jeffhandley jeffhandley added this to the 1.0.0 (GA) milestone Feb 24, 2026
@stephentoub stephentoub marked this pull request as ready for review February 24, 2026 02:14
@stephentoub stephentoub merged commit 124b43b into main Feb 24, 2026
11 checks passed
@stephentoub stephentoub deleted the copilot/add-explicit-protected-constructors branch February 24, 2026 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking-change This issue or PR introduces a breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants