Add explicit [Experimental] protected constructors to McpClient and McpServer#1363
Merged
stephentoub merged 5 commits intomainfrom Feb 24, 2026
Merged
Conversation
…and McpServer Co-authored-by: stephentoub <[email protected]>
stephentoub
reviewed
Feb 23, 2026
Contributor
stephentoub
left a comment
There was a problem hiding this comment.
Also please fix the PR title and description
Co-authored-by: stephentoub <[email protected]>
Contributor
Author
Updated in ff5e1dc. I'm unable to change the PR title directly — could you update it to "Add explicit [Experimental] protected constructors to McpClient and McpServer"? |
Copilot
AI
changed the title
[WIP] Add explicit protected constructors in McpClient and McpServer
Add explicit [Experimental] protected constructors to McpClient and McpServer
Feb 23, 2026
jeffhandley
reviewed
Feb 24, 2026
…Server Co-authored-by: jeffhandley <[email protected]>
stephentoub
approved these changes
Feb 24, 2026
jeffhandley
approved these changes
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds explicit protected constructors annotated with
[Experimental(MCPEXP002)]to the abstractMcpClientandMcpServerbase classes, making subclassing an explicitly experimental operation. Introduces a newMCPEXP002diagnostic ID distinct from the existingMCPEXP001(Tasks/Extensions), with its URL pointing to this pull request. Suppresses theMCPEXP002diagnostic in internal implementation classes (McpClientImpl,McpServerImpl,DestinationBoundMcpServer) and a test class (TestServerForIChatClient) that derive from them. DocumentsMCPEXP002indocs/list-of-diagnostics.md.💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.